Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add multi_json as a gem dependency? #95

Closed
kgrz opened this Issue · 3 comments

2 participants

@kgrz

Since the Sinatra::JSON module uses multi_json internally, shouldn't it be a dependency and load it automatically?

@zzak
Owner

Good point, could you send a patch?

@kgrz

Done.

One more thing: Shouldn't this module do much more than just providing a helper method? I mean, adding a full-blown module that does almost the same thing as to_json (plus changing the HTTP headers of course)

What I thought initially when imagining the functionality would be akin to what Grape does with its format: json call: Convert every response into a JSON string implicitly. Would this be a good option to have? / cc @rkh

@zzak
Owner

I think maintaining a full blown module is going to be hard, but I'm closing this in favor of your patch for further discussion.

@zzak zzak closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.