Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Doesn't work with sinatra 1.4 #98

Closed
rubycut opened this Issue · 10 comments

4 participants

@rubycut

Latest sinatra-contrib is 1.3.2 and it doesn't work with sinatra 1.4 because it depends on:

sinatra (~> 1.3.0)
@rubycut

Strange, version is bumped here: 4fdace3

That was long ago, why gem wasn't released?

@rkh
Owner
rkh commented

Specs didn't pass until recently.

@TrevorBramble what needs to get done for a release?

@kgrz

One test still doesn't pass. Details: #96 (comment)

@TrevorBramble

@rkh If there's anything other than that outstanding failure, I'm not aware of it. Looking into it tomorrow.

@rkh
Owner
rkh commented

\o/

@TrevorBramble

@rkh So I'm not sure I followed the outcome of sinatra/sinatra#692. Should ":name.:format" still work?

  1) Sinatra::Decompile 
     Failure/Error: it { should decompile(":name.:format") }
       expected Sinatra::Application to decompile /\A((?:[^\.\/?#%]|(?:%[^2].|%[2][^Ee]))+)(?:\.|%2[Ee])((?:[^\/?#%]|(?:%[^2].|%[2][^Ee]))+)\z/ with ["name", "format"] to ":name.:format", but was /\A((?:[^\.\/?#%]|(?:%[^2].|%[2][^Ee]))+)(?:\.|%2[Ee])((?:[^\/?#%]|(?:%[^2].|%[2][^Ee]))+)\z/
     # ./spec/decompile_spec.rb:30:in `block (2 levels) in <top (required)>'

If so, I'm going to need some guidance on how decompile should be modified to re-align with compile.

@rkh
Owner
rkh commented

I can look into this. BTW, I have a new parser (the only thing of Sinatra 2.0 that's more or less done) that will make decompile obsolete.

@TrevorBramble

That's a relief. This is really tightly coupled code split across the two repos. =^/

@rkh
Owner
rkh commented

OK, decode is fixed for now. I really don't like the code, but I don't see much work going into pattern compilation any time soon (or I'll backport my parser to 1.x), so I guess that's OK for now.

There's still a segfault when running tests on 2.0 sometimes, but as that's probably a Ruby bug, it shouldn't block a release, I guess.

@TrevorBramble

Updated the gem. Thanks @rkh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.