Add Sinatra::WebDAV #143

Merged
merged 1 commit into from May 3, 2016

Conversation

Projects
None yet
2 participants
@yegortimoshenko
Contributor

yegortimoshenko commented Aug 12, 2014

This adds full WebDAV support (except for #lock method, see below) and fixes sinatra/sinatra#897 (also see sinatra/sinatra#912).

This is not to be merged yet, since #lock method doesn't work yet (it conflicts with existing #lock method for Mutex locking). This issue will be referenced here.

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Aug 12, 2014

Member

Awesome, thanks for cleaning this up!

Would you be able to add some tests as well?

Member

zzak commented Aug 12, 2014

Awesome, thanks for cleaning this up!

Would you be able to add some tests as well?

@yegortimoshenko

This comment has been minimized.

Show comment
Hide comment
@yegortimoshenko

yegortimoshenko Aug 12, 2014

Contributor

Sure! This one is WIP, will add soon.

Contributor

yegortimoshenko commented Aug 12, 2014

Sure! This one is WIP, will add soon.

@zzak zzak added the feature label May 22, 2015

@zzak zzak added this to the 1.5 milestone May 22, 2015

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak May 22, 2015

Member

@yegortimoschenko Sorry for the late response!

We should consider this for the next MINOR patch level release, but we can't do anything for now.

Thanks again for your contribution!

Member

zzak commented May 22, 2015

@yegortimoschenko Sorry for the late response!

We should consider this for the next MINOR patch level release, but we can't do anything for now.

Thanks again for your contribution!

@yegortimoshenko

This comment has been minimized.

Show comment
Hide comment
@yegortimoshenko

yegortimoshenko May 27, 2015

Contributor

@zzak Yeah, sure.

Sorry for not including tests.

Tell me your decision about WebDAV LOCK verb. According to Sinatra APIs, the according method should be called #lock, but it is already taken. How should I call it?

Contributor

yegortimoshenko commented May 27, 2015

@zzak Yeah, sure.

Sorry for not including tests.

Tell me your decision about WebDAV LOCK verb. According to Sinatra APIs, the according method should be called #lock, but it is already taken. How should I call it?

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak May 3, 2016

Member

I'll merge this for now and we can consider the best way to move forward wrt lock

Member

zzak commented May 3, 2016

I'll merge this for now and we can consider the best way to move forward wrt lock

@zzak zzak merged commit 9ae64e5 into sinatra:master May 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

zzak added a commit to zzak/sinatra-contrib that referenced this pull request Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment