Catch LoadError from Tilt with uninstalled template engine #175

Merged
merged 1 commit into from Jul 21, 2016

Conversation

Projects
None yet
2 participants
@maafy6
Contributor

maafy6 commented Sep 25, 2015

template_for looks through all the engines to find one that can handle the template. For versions of Tilt that don't respond to .mapping, this triggers a require on the engine its checking. So, for instance, if you are using the slim engine for html, you have to have the erubis and haml engines installed as well.

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak May 4, 2016

Member

This is very true!

I ran into this recently with RedCloth, and found it frustrating we have to lock an older version of the gem just to get our tests to pass.

Let's see if this fixes it, or at least makes the ux better <3

Member

zzak commented May 4, 2016

This is very true!

I ran into this recently with RedCloth, and found it frustrating we have to lock an older version of the gem just to get our tests to pass.

Let's see if this fixes it, or at least makes the ux better <3

@zzak zzak merged commit 4b53d27 into sinatra:master Jul 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jul 21, 2016

Member

@maafy6 Thank you!

Member

zzak commented Jul 21, 2016

@maafy6 Thank you!

zzak added a commit to zzak/sinatra-contrib that referenced this pull request Jul 22, 2016

Merge pull request #175 from maafy6/master
Catch LoadError from Tilt with uninstalled template engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment