New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining decompile call #205

Merged
merged 1 commit into from Jun 25, 2016

Conversation

Projects
None yet
2 participants
@stjhimy
Contributor

stjhimy commented Jun 24, 2016

No description provided.

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jun 25, 2016

Member

This is just a step in the right direction, but still we have to rethink how Namespace deals with routes from Mustermann.

Member

zzak commented Jun 25, 2016

This is just a step in the right direction, but still we have to rethink how Namespace deals with routes from Mustermann.

@stjhimy

This comment has been minimized.

Show comment
Hide comment
@stjhimy

stjhimy Jun 25, 2016

Contributor

Yes, this is just a remaining code removal from fef4722

This just fix some of the specs that cannot find the decompile method:

Sinatra::Namespace HTTP PATCH conditions...
     Failure/Error: mock_app { namespace(*args, &block) }
     NoMethodError:
       undefined method `decompile' for #<Class:0x007fc41aeff520>
Contributor

stjhimy commented Jun 25, 2016

Yes, this is just a remaining code removal from fef4722

This just fix some of the specs that cannot find the decompile method:

Sinatra::Namespace HTTP PATCH conditions...
     Failure/Error: mock_app { namespace(*args, &block) }
     NoMethodError:
       undefined method `decompile' for #<Class:0x007fc41aeff520>
@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jun 25, 2016

Member

Correct, I will merge it, but then I have to rebase my local hacks :(

Member

zzak commented Jun 25, 2016

Correct, I will merge it, but then I have to rebase my local hacks :(

@zzak zzak merged commit dce0f3b into sinatra:master Jun 25, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@stjhimy stjhimy deleted the stjhimy:decompile branch Jul 20, 2016

zzak added a commit to zzak/sinatra-contrib that referenced this pull request Jul 22, 2016

Merge pull request #205 from stjhimy/decompile
Remove remaining decompile call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment