Fix issue prefixing routes with conditions #208

Merged
merged 1 commit into from Jul 20, 2016

Projects

None yet

2 participants

@jkowens
Contributor
jkowens commented Jul 20, 2016

Update to make the following namespace specs pass:

https://github.com/sinatra/sinatra-contrib/blob/9500d76/spec/namespace_spec.rb#L170-L209

@zzak
Member
zzak commented Jul 20, 2016

I have no idea why ruby-head and jruby are failing, but unrelated we should probably drop jruby 1.x support anyways.

Thanks for your patch @jkowens!

@jkowens
Contributor
jkowens commented Jul 20, 2016

Yeah, I don't think JRuby 1.x is compatible with Rack 2.0. I'm not sure why 'ruby-head' is failing tho.

@jkowens
Contributor
jkowens commented Jul 20, 2016

Looks like 'yajl-ruby' isn't compatible with Ruby 2.4 yet. That's why 'ruby-head' is failing.

@zzak
Member
zzak commented Jul 20, 2016

@jkowens Ah yeah, there is a patch to fix that already, I suppose we don't need to care about it.

I'll merge this and fix the build. Thank you!!

@zzak zzak merged commit f9a0605 into sinatra:master Jul 20, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@jkowens jkowens deleted the unknown repository branch Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment