New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue prefixing routes with conditions #208

Merged
merged 1 commit into from Jul 20, 2016

Conversation

Projects
None yet
2 participants
@jkowens
Member

jkowens commented Jul 20, 2016

Update to make the following namespace specs pass:

https://github.com/sinatra/sinatra-contrib/blob/9500d76/spec/namespace_spec.rb#L170-L209

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jul 20, 2016

Member

I have no idea why ruby-head and jruby are failing, but unrelated we should probably drop jruby 1.x support anyways.

Thanks for your patch @jkowens!

Member

zzak commented Jul 20, 2016

I have no idea why ruby-head and jruby are failing, but unrelated we should probably drop jruby 1.x support anyways.

Thanks for your patch @jkowens!

@jkowens

This comment has been minimized.

Show comment
Hide comment
@jkowens

jkowens Jul 20, 2016

Member

Yeah, I don't think JRuby 1.x is compatible with Rack 2.0. I'm not sure why 'ruby-head' is failing tho.

Member

jkowens commented Jul 20, 2016

Yeah, I don't think JRuby 1.x is compatible with Rack 2.0. I'm not sure why 'ruby-head' is failing tho.

@jkowens

This comment has been minimized.

Show comment
Hide comment
@jkowens

jkowens Jul 20, 2016

Member

Looks like 'yajl-ruby' isn't compatible with Ruby 2.4 yet. That's why 'ruby-head' is failing.

Member

jkowens commented Jul 20, 2016

Looks like 'yajl-ruby' isn't compatible with Ruby 2.4 yet. That's why 'ruby-head' is failing.

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jul 20, 2016

Member

@jkowens Ah yeah, there is a patch to fix that already, I suppose we don't need to care about it.

I'll merge this and fix the build. Thank you!!

Member

zzak commented Jul 20, 2016

@jkowens Ah yeah, there is a patch to fix that already, I suppose we don't need to care about it.

I'll merge this and fix the build. Thank you!!

@zzak zzak merged commit f9a0605 into sinatra:master Jul 20, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@jkowens jkowens deleted the jkowens:fix_namespacing branch Jul 21, 2016

zzak added a commit to zzak/sinatra-contrib that referenced this pull request Jul 22, 2016

Merge pull request #208 from jkowens/fix_namespacing
Fix issue prefixing routes with conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment