sinatra/cookies: cookies.delete did not pass the options to @response.delete_cookie #72

Merged
merged 1 commit into from Nov 9, 2012

Conversation

Projects
None yet
2 participants
@thibautsacreste
Contributor

thibautsacreste commented Nov 9, 2012

Hi,

I noticed an issue when trying to delete cookies with custom cookie options. The custom path and domain were not being set on the response Set-Cookie header and therefore the cookie was not being deleted by the browser.

Hope this helps,

Thibaut

rkh added a commit that referenced this pull request Nov 9, 2012

Merge pull request #72 from thibautsacreste/master
sinatra/cookies: cookies.delete did not pass the options to @response.delete_cookie

@rkh rkh merged commit 59cd6af into sinatra:master Nov 9, 2012

zzak pushed a commit to zzak/sinatra-contrib that referenced this pull request Jul 22, 2016

Merge pull request #72 from thibautsacreste/master
sinatra/cookies: cookies.delete did not pass the options to @response.delete_cookie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment