This is not a final PR #103

Merged
merged 2 commits into from Mar 15, 2013

Projects

None yet

2 participants

Member
kgrz commented Mar 12, 2013

There were some issue with Redcarpet gem while parsing inline html tags which crapped up the structure of the generated HTML content from the rake task. And, there are some markdown formatting issues in some of the readmes in the main Sinatra repos — I've sent a PR there. Those changes are added to this PR.

I will merge these changes with the 1.4.x branch and squashing my previous commits to the same once this gets approved.

The syntax highlighting is done by Coderay gem that is packed in Kramdown.

@rkh: Let me know if I should remove the ToC removal code and use yours instead. As I pointed out earlier, I went the Nokogiri path to ensure support to other language READMEs in case ToCs are added to them in the future.

kgrz added some commits Mar 12, 2013
@kgrz kgrz Markdown parsing is done by Kramdown now instead of Redcarpet.
Redcarpet does not parse inline HTML tags properly. Syntax
highlighting comes free with Kramdown in the form of Coderay gem.

The previous commit's generated html files were error prone. These are
due to improper parsing of Redcarpet gem and because of errors in
Readmes which have been corrected now.
1089a9c
@kgrz kgrz deleted book.html and changes.txt since they are now linked 7d7770b
Owner
rkh commented Mar 14, 2013

@rkh: Let me know if I should remove the ToC removal code and use yours instead. As I pointed out earlier, I went the Nokogiri path to ensure support to other language READMEs in case ToCs are added to them in the future.

I guess it's fine if it works right now.

What's the status on this? I'm ready to release 1.4.

Member
kgrz commented Mar 14, 2013

It works as of now. All the READMEs get parsed properly. The Rakefile needs more cleanup -- specifically, I wish to modularize the entire file but that can wait and not be a hindrance to the 1.4.0 release.

@rkh rkh merged commit 71d7122 into sinatra:1.4.x Mar 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment