Escape [] to avoid Maruku warnings #105

Merged
merged 1 commit into from Sep 11, 2013

Conversation

Projects
None yet
3 participants
@mattwildig
Contributor

mattwildig commented Mar 28, 2013

Generating the site was producing warnings:

 ___________________________________________________________________________
| Maruku tells you:
+---------------------------------------------------------------------------
| Could not find ref_id = "md_im_linksource_httpsgithubcommichaelminterfractureurl_nil" for md_link([
|       md_im_link(["Source"], "https://github.com/michaelminter/fracture-url", nil)
| ],"md_im_linksource_httpsgithubcommichaelminterfractureurl_nil")
| Available refs are []
+---------------------------------------------------------------------------
!/Users/matt/.rvm/gems/ruby-1.9.3-p385/gems/maruku-0.6.1/lib/maruku/errors_management.rb:49:in `maruku_error'
!/Users/matt/.rvm/gems/ruby-1.9.3-p385/gems/maruku-0.6.1/lib/maruku/output/to_html.rb:716:in `to_html_link'
!/Users/matt/.rvm/gems/ruby-1.9.3-p385/gems/maruku-0.6.1/lib/maruku/output/to_html.rb:970:in `block in array_to_html'
!/Users/matt/.rvm/gems/ruby-1.9.3-p385/gems/maruku-0.6.1/lib/maruku/output/to_html.rb:961:in `each'
!/Users/matt/.rvm/gems/ruby-1.9.3-p385/gems/maruku-0.6.1/lib/maruku/output/to_html.rb:961:in `array_to_html'
\___________________________________________________________________________
Not creating a link for ref_id = "md_im_linksource_httpsgithubcommichaelminterfractureurl_nil".

Escaping the [] chars removed these warnings (and makes the brackets appear in the html, which I think was the intent.)

@randomecho

This comment has been minimized.

Show comment Hide comment
@randomecho

randomecho Mar 29, 2013

Contributor

Could also be rewritten to either remove the brackets entirely

- [Source](https://github.com/michaelminter/fracture-url)

Or replace them with parentheses

- ([Source](https://github.com/michaelminter/fracture-url))

Guess it depends on how you want to copy edit that line.

Contributor

randomecho commented Mar 29, 2013

Could also be rewritten to either remove the brackets entirely

- [Source](https://github.com/michaelminter/fracture-url)

Or replace them with parentheses

- ([Source](https://github.com/michaelminter/fracture-url))

Guess it depends on how you want to copy edit that line.

kgrz added a commit that referenced this pull request Sep 11, 2013

Merge pull request #105 from mattwildig/escape_brackets
Escape [] to avoid Maruku warnings

@kgrz kgrz merged commit 2b8a775 into sinatra:master Sep 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment