Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Revert "rack.sessions.options no longer contains :secret in 1.3"
This issue has been fixed in Rack

This reverts commit d0df5fb.
  • Loading branch information
rkh committed May 9, 2011
1 parent 6f33e1b commit def6fb5
Showing 1 changed file with 28 additions and 30 deletions.
58 changes: 28 additions & 30 deletions test/helpers_test.rb
Expand Up @@ -298,36 +298,34 @@ def test_default
assert_body 'ok'
end

# # have to write proper tests or remove those, since they no longer work
# # on Rack 1.3
# it 'sets a default session secret' do
# mock_app do
# enable :sessions
# get '/' do
# secret = env['rack.session.options'][:secret]
# assert secret
# assert_equal secret, settings.session_secret
# 'ok'
# end
# end
#
# get '/'
# assert_body 'ok'
# end
#
# it 'allows disabling session secret' do
# mock_app do
# enable :sessions
# disable :session_secret
# get '/' do
# assert !env['rack.session.options'].include?(:session_secret)
# 'ok'
# end
# end
#
# get '/'
# assert_body 'ok'
# end
it 'sets a default session secret' do
mock_app do
enable :sessions
get '/' do
secret = env['rack.session.options'][:secret]
assert secret
assert_equal secret, settings.session_secret
'ok'
end
end

get '/'
assert_body 'ok'
end

it 'allows disabling session secret' do
mock_app do
enable :sessions
disable :session_secret
get '/' do
assert !env['rack.session.options'].include?(:session_secret)
'ok'
end
end

get '/'
assert_body 'ok'
end

it 'accepts an options hash' do
mock_app do
Expand Down

0 comments on commit def6fb5

Please sign in to comment.