Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sinatra::RespondWith providing mime_type and Accept header #1141

Closed
zzak opened this issue Jul 21, 2016 · 2 comments
Closed

Sinatra::RespondWith providing mime_type and Accept header #1141

zzak opened this issue Jul 21, 2016 · 2 comments

Comments

@zzak
Copy link
Member

@zzak zzak commented Jul 21, 2016

This ticket is copied from sinatra/sinatra-contrib#149

@JonMidhir
Copy link
Contributor

@JonMidhir JonMidhir commented Jan 31, 2017

Have investigated this and I can only reproduce one of the two bugs now.

  • When passing the header application/rss+xml the /comics/:name/feed route will indeed 404.

  • When visiting /comics/:name/rss10 it's possible the 406 was actually a template engine error and fixed by this commit: de8ebed. Now it will 500 instead :)

I can take this and work on a fix if it's still useful. I guess there are two ways to go about it though, mime_type could take additional options for version etc. Or these can simply be parsed out of the string later.

@zzak
Copy link
Member Author

@zzak zzak commented Mar 4, 2017

@johnvoloski So we can close this ticket? 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.