New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sinatra-contrib gem into tree #1145

Closed
zzak opened this Issue Jul 21, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@zzak
Member

zzak commented Jul 21, 2016

Haven't tried this yet but @cypher wrote up an article about it!

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jul 22, 2016

Member
  • make sure sinatra gem doesn't ship w/ sinatra-contrib files in the package
Member

zzak commented Jul 22, 2016

  • make sure sinatra gem doesn't ship w/ sinatra-contrib files in the package

@zzak zzak closed this in #1147 Jul 23, 2016

@zzak zzak reopened this Jul 23, 2016

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jul 23, 2016

Member
  • hook up tests
Member

zzak commented Jul 23, 2016

  • hook up tests
@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jul 23, 2016

Member

Confirmed, only sinatra files are included in package:

ls -aslh /home/zzak/.gem/ruby/2.3.1/gems/sinatra-2.0.0.pre.alpha/
total 872K
4.0K drwxrwxr-x   4 zzak zzak 4.0K  7月 23 12:04 .
 12K drwxrwxr-x 209 zzak zzak  12K  7月 23 12:04 ..
4.0K -rw-rw-r--   1 zzak zzak 3.5K  7月 23 12:04 AUTHORS.md
 56K -rw-rw-r--   1 zzak zzak  53K  7月 23 12:04 CHANGELOG.md
8.0K -rw-rw-r--   1 zzak zzak 4.8K  7月 23 12:04 CONTRIBUTING.md
4.0K drwxrwxr-x   2 zzak zzak 4.0K  7月 23 12:04 examples
4.0K -rw-rw-r--   1 zzak zzak 1.4K  7月 23 12:04 Gemfile
4.0K drwxrwxr-x   3 zzak zzak 4.0K  7月 23 12:04 lib
4.0K -rw-rw-r--   1 zzak zzak 1.2K  7月 23 12:04 LICENSE
4.0K -rw-rw-r--   1 zzak zzak 1.5K  7月 23 12:04 MAINTENANCE.md
8.0K -rw-rw-r--   1 zzak zzak 6.0K  7月 23 12:04 Rakefile
 80K -rw-rw-r--   1 zzak zzak  79K  7月 23 12:04 README.de.md
 72K -rw-rw-r--   1 zzak zzak  70K  7月 23 12:04 README.es.md
 80K -rw-rw-r--   1 zzak zzak  80K  7月 23 12:04 README.fr.md
 20K -rw-rw-r--   1 zzak zzak  19K  7月 23 12:04 README.hu.md
 96K -rw-rw-r--   1 zzak zzak  93K  7月 23 12:04 README.ja.md
 84K -rw-rw-r--   1 zzak zzak  84K  7月 23 12:04 README.ko.md
 72K -rw-rw-r--   1 zzak zzak  72K  7月 23 12:04 README.md
 44K -rw-rw-r--   1 zzak zzak  43K  7月 23 12:04 README.pt-br.md
 20K -rw-rw-r--   1 zzak zzak  18K  7月 23 12:04 README.pt-pt.md
108K -rw-rw-r--   1 zzak zzak 107K  7月 23 12:04 README.ru.md
 72K -rw-rw-r--   1 zzak zzak  71K  7月 23 12:04 README.zh.md
4.0K -rw-rw-r--   1 zzak zzak 2.9K  7月 23 12:04 SECURITY.md
4.0K -rw-rw-r--   1 zzak zzak 1.2K  7月 23 12:04 sinatra.gemspec
4.0K -rw-rw-r--   1 zzak zzak  112  7月 23 12:04 .yardopts

From the spec:

  s.files = %w(.yardopts AUTHORS.md CHANGELOG.md CONTRIBUTING.md Gemfile LICENSE MAINTENANCE.md Rakefile SECURITY.md sinatra.gemspec) + Dir['README*.md', 'lib/**/*', 'examples/*']
Member

zzak commented Jul 23, 2016

Confirmed, only sinatra files are included in package:

ls -aslh /home/zzak/.gem/ruby/2.3.1/gems/sinatra-2.0.0.pre.alpha/
total 872K
4.0K drwxrwxr-x   4 zzak zzak 4.0K  7月 23 12:04 .
 12K drwxrwxr-x 209 zzak zzak  12K  7月 23 12:04 ..
4.0K -rw-rw-r--   1 zzak zzak 3.5K  7月 23 12:04 AUTHORS.md
 56K -rw-rw-r--   1 zzak zzak  53K  7月 23 12:04 CHANGELOG.md
8.0K -rw-rw-r--   1 zzak zzak 4.8K  7月 23 12:04 CONTRIBUTING.md
4.0K drwxrwxr-x   2 zzak zzak 4.0K  7月 23 12:04 examples
4.0K -rw-rw-r--   1 zzak zzak 1.4K  7月 23 12:04 Gemfile
4.0K drwxrwxr-x   3 zzak zzak 4.0K  7月 23 12:04 lib
4.0K -rw-rw-r--   1 zzak zzak 1.2K  7月 23 12:04 LICENSE
4.0K -rw-rw-r--   1 zzak zzak 1.5K  7月 23 12:04 MAINTENANCE.md
8.0K -rw-rw-r--   1 zzak zzak 6.0K  7月 23 12:04 Rakefile
 80K -rw-rw-r--   1 zzak zzak  79K  7月 23 12:04 README.de.md
 72K -rw-rw-r--   1 zzak zzak  70K  7月 23 12:04 README.es.md
 80K -rw-rw-r--   1 zzak zzak  80K  7月 23 12:04 README.fr.md
 20K -rw-rw-r--   1 zzak zzak  19K  7月 23 12:04 README.hu.md
 96K -rw-rw-r--   1 zzak zzak  93K  7月 23 12:04 README.ja.md
 84K -rw-rw-r--   1 zzak zzak  84K  7月 23 12:04 README.ko.md
 72K -rw-rw-r--   1 zzak zzak  72K  7月 23 12:04 README.md
 44K -rw-rw-r--   1 zzak zzak  43K  7月 23 12:04 README.pt-br.md
 20K -rw-rw-r--   1 zzak zzak  18K  7月 23 12:04 README.pt-pt.md
108K -rw-rw-r--   1 zzak zzak 107K  7月 23 12:04 README.ru.md
 72K -rw-rw-r--   1 zzak zzak  71K  7月 23 12:04 README.zh.md
4.0K -rw-rw-r--   1 zzak zzak 2.9K  7月 23 12:04 SECURITY.md
4.0K -rw-rw-r--   1 zzak zzak 1.2K  7月 23 12:04 sinatra.gemspec
4.0K -rw-rw-r--   1 zzak zzak  112  7月 23 12:04 .yardopts

From the spec:

  s.files = %w(.yardopts AUTHORS.md CHANGELOG.md CONTRIBUTING.md Gemfile LICENSE MAINTENANCE.md Rakefile SECURITY.md sinatra.gemspec) + Dir['README*.md', 'lib/**/*', 'examples/*']
@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak
Member

zzak commented Jul 23, 2016

@zzak zzak closed this Jul 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment