Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backports dependency from sinatra-contrib #1207

Closed
mwpastore opened this issue Nov 25, 2016 · 3 comments
Closed

Remove backports dependency from sinatra-contrib #1207

mwpastore opened this issue Nov 25, 2016 · 3 comments

Comments

@mwpastore
Copy link
Member

@mwpastore mwpastore commented Nov 25, 2016

Now that the minimum Ruby version is 2.2 (.2 due to Rack 2), can we remove sinatra-contrib's dependency on backports? Tests pass on 2.2.2 without it with some light refactoring around String#underscore and Object#try.

Why is Rack::Test a runtime dependency and not a development dependency?

I've submitted a PR with these changes but wanted to see what "tribal knowledge" might be out there.

mwpastore added a commit to mwpastore/sinatra that referenced this issue Nov 25, 2016
* Remove backports
* Work around Object#try and String#underscore
* Make Rack::Test a development dependency
mwpastore added a commit to mwpastore/sinatra that referenced this issue Nov 26, 2016
* Remove backports
* Work around Object#try and String#underscore
* Make Rack::Test a development dependency
@zzak
Copy link
Member

@zzak zzak commented Dec 14, 2016

I think it's ok, but want to focus what limited time budget I have on shipping and will probably put this kind of stuff off until after the release.

@zzak zzak added this to the Beyond milestone Dec 14, 2016
@zzak zzak changed the title sinatra-contrib dependencies Remove backports dependency from sinatra-contrib Jan 14, 2017
@zzak
Copy link
Member

@zzak zzak commented Jan 14, 2017

#1208 resolves this

mwpastore added a commit to mwpastore/sinatra that referenced this issue Jan 14, 2017
* Remove backports
* Work around Object#try and String#underscore
@namusyaka namusyaka closed this in 6417330 Mar 18, 2018
namusyaka added a commit that referenced this issue Mar 18, 2018
Sinatra::Contrib dependency updates. Fixes #1207
namusyaka added a commit that referenced this issue Mar 19, 2018
zzak added a commit that referenced this issue Mar 19, 2018
namusyaka added a commit that referenced this issue Mar 19, 2018
* Remove backports
* Work around Object#try and String#underscore
@namusyaka namusyaka reopened this Mar 19, 2018
@ChrisBAshton
Copy link

@ChrisBAshton ChrisBAshton commented Apr 26, 2019

Can you close this issue please? #1208 has been merged 🎉

@jkowens jkowens closed this Aug 24, 2019
jkowens pushed a commit that referenced this issue Mar 13, 2020
* Remove backports
* Work around Object#try and String#underscore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.