New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erubi support #1487

Open
namusyaka opened this Issue Oct 28, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@namusyaka
Member

namusyaka commented Oct 28, 2018

As discussed at #1475 , the erubi gem has been released and it's adopted in rails.
Of course we can use erubi on Sinatra by installing the gem because tilt will automatically enable erubi as an ERB template engine.

However I think we can support the erubi explicitly like erubis. If this issue is reasonable, we will work on the docs, testing, and the sinatra-contrib library.

Please let me know if you're interested in working on the issue.

@tkmru

This comment has been minimized.

tkmru commented Oct 30, 2018

I'm interested in it, I'll work on this issue.

I'm sorry I closed pull request earlier.

@namusyaka

This comment has been minimized.

Member

namusyaka commented Oct 30, 2018

@tkmru No worry, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment