Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erubi support #1487

Closed
namusyaka opened this issue Oct 28, 2018 · 2 comments
Closed

Erubi support #1487

namusyaka opened this issue Oct 28, 2018 · 2 comments
Labels
good first issue help wanted

Comments

@namusyaka
Copy link
Member

namusyaka commented Oct 28, 2018 •
edited

As discussed at #1475 , the erubi gem has been released and it's adopted in rails.
Of course we can use erubi on Sinatra by installing the gem because tilt will automatically enable erubi as an ERB template engine.

However I think we can support the erubi explicitly like erubis. If this issue is reasonable, we will work on the docs, testing, and the sinatra-contrib library.

Please let me know if you're interested in working on the issue.
@tkmru
Copy link
Contributor

tkmru commented Oct 30, 2018 •
edited

I'm interested in it, I'll work on this issue.

I'm sorry I closed pull request earlier.

@namusyaka
Copy link
Member Author

@tkmru No worry, go ahead!

@tkmru tkmru mentioned this issue Nov 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@namusyaka @tkmru