Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop thin support #1624

Closed
namusyaka opened this issue Jul 5, 2020 · 7 comments
Closed

drop thin support #1624

namusyaka opened this issue Jul 5, 2020 · 7 comments
Labels
Milestone

Comments

@namusyaka
Copy link
Contributor

@namusyaka namusyaka commented Jul 5, 2020

As per rack/rack@98d9cf5, it's time to drop the support for thin.
Does anyone want to take this issue?

@rkmathi
Copy link
Contributor

@rkmathi rkmathi commented Jul 26, 2020

@namusyaka Hi
I fixed it to try in #1627.
If I'm wrong, I'd be happy to let you know.

@matti
Copy link

@matti matti commented Jul 29, 2020

I never managed to get streaming work with puma, only with thin. Worried.

@namusyaka
Copy link
Contributor Author

@namusyaka namusyaka commented Aug 1, 2020

I guess the rainbows can handle the streaming feature. See #1627

@esparta
Copy link
Contributor

@esparta esparta commented Aug 9, 2020

May I propose to re-open this issue in order to link the update of documentation on different languages?
once all the docs are done, close it?

@dentarg
Copy link

@dentarg dentarg commented Aug 9, 2020

@esparta I would suggest creating a new issue about the docs (easier to understand what's need to be done then)

@namusyaka namusyaka reopened this Aug 30, 2020
@namusyaka
Copy link
Contributor Author

@namusyaka namusyaka commented Aug 30, 2020

As I noted in sinatra/sinatra.github.com#274, we'll wait and see what happens around rack/thin for making a decision on what server should be choosed. This indicates there is a possibility of reverting #1627 partially (In any case the integration test with rainbows can be helpful).

@namusyaka namusyaka added this to the v2.1.0 milestone Aug 30, 2020
@namusyaka
Copy link
Contributor Author

@namusyaka namusyaka commented Sep 4, 2020

We'll use rainbows in our development environment, but I restored thin support in 342758a because of macournoyer/thin@b201525.
However, in order to use thin with sinatra smoothly, macournoyer/thin#369 should be merged.

@namusyaka namusyaka closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.