http is not installed, skipping integration tests #670

Closed
patriciomacadden opened this Issue Mar 10, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Member

patriciomacadden commented Mar 10, 2013

When I'm running the tests I get this warning:

http is not installed, skipping integration tests

I did some research and I found this:

Seems like http means "load Net HTTP Server", but this is not happening and that's why the tests are complaining.

While researching this problem I changed:

set :server, %w[HTTP webrick]

(changed HTTP instead of http because this server is selected using -s HTTP)

def installed?
  return @installed unless @installed.nil?
  s = server == 'HTTP' ? 'net/http/server' : server
  require s
  @installed = true
rescue LoadError
  warn "#{server} is not installed, skipping integration tests"
  @installed = false
end

And now I get all tests running, but 2 tests are failing (logs once in development mode and starts the correct server).

Am I right? If so, I'll send a PR with this changes and the failing tests fixed.

Owner

rkh commented Mar 10, 2013

Yes, I guess you're right.

Member

patriciomacadden commented Mar 10, 2013

I'm closing this issue and creating a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment