Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

exceptions after filters not handled properly? #673

Closed
rkh opened this Issue Mar 12, 2013 · 4 comments

Comments

Projects
None yet
3 participants
Member

patriciomacadden commented Mar 12, 2013

I'll take a look later if no one minds.

Owner

rkh commented Mar 12, 2013

Check out the padrino issue, it includes a test case.

This was referenced Mar 13, 2013

Contributor

nesquena commented Mar 13, 2013

Hey guys, in the process of migrating padrino to support sinatra 1.4, I encountered an issue with how sinatra handled exceptions in after blocks. That's why this was created. My pull request above fixes the issue and passes all sinatra tests. Let me know if it's ok.

Member

patriciomacadden commented Mar 13, 2013

Great! I've tried the same thing but didn't worked for me. Maybe I did something wrong and didn't noticed what.

@rkh rkh closed this in 854c32c Mar 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment