New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mustermann for patterns #1086

Merged
merged 4 commits into from May 4, 2016

Conversation

Projects
None yet
5 participants
@rkh
Member

rkh commented Jan 30, 2016

This PR makes Sinatra use Mustermann. It also updates the pattern to what I'd like the Sinatra 2.0 syntax to be, it is generally compatible with the old syntax.

This will also lead to more meaningful errors on broken patterns.

Advanced Mustermann features are not yet exposed.

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Jan 30, 2016

Member

Failing on JRuby atm.

Member

rkh commented Jan 30, 2016

Failing on JRuby atm.

@kgrz

This comment has been minimized.

Show comment
Hide comment
@kgrz

kgrz Mar 30, 2016

Member

The tests are passing if I run one file at a time. I ran the helpers_test and static_test, and both pass on jruby 9.0.1.0 (2.2.2) 2015-09-02 583f336 Java HotSpot(TM) 64-Bit Server VM 25.45-b02 on 1.8.0_45-b14 +jit [darwin-x86_64]

Is this because we are using a pre-release jRuby version for the test? I see this in travis logs:

jruby 9.0.0.0.pre1 (2.2.0p0) 2015-01-20 d537cab Java HotSpot(TM) 64-Bit Server VM 24.76-b04 on 1.7.0_76-b13 +jit [linux-amd64]

Member

kgrz commented Mar 30, 2016

The tests are passing if I run one file at a time. I ran the helpers_test and static_test, and both pass on jruby 9.0.1.0 (2.2.2) 2015-09-02 583f336 Java HotSpot(TM) 64-Bit Server VM 25.45-b02 on 1.8.0_45-b14 +jit [darwin-x86_64]

Is this because we are using a pre-release jRuby version for the test? I see this in travis logs:

jruby 9.0.0.0.pre1 (2.2.0p0) 2015-01-20 d537cab Java HotSpot(TM) 64-Bit Server VM 24.76-b04 on 1.7.0_76-b13 +jit [linux-amd64]

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak May 4, 2016

Member

Build is green with latest JRuby (9.1.0.0)

Member

zzak commented May 4, 2016

Build is green with latest JRuby (9.1.0.0)

@zzak zzak merged commit aa4ad35 into master May 4, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zzak zzak deleted the mustermann branch May 4, 2016

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka May 4, 2016

Member

Awesome 🎉

Member

namusyaka commented May 4, 2016

Awesome 🎉

@kgrz

This comment has been minimized.

Show comment
Hide comment
@kgrz

kgrz May 4, 2016

Member

👏👏👏👏

Member

kgrz commented May 4, 2016

👏👏👏👏

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh May 4, 2016

Member

🎉

Member

rkh commented May 4, 2016

🎉

@vipulnsward

This comment has been minimized.

Show comment
Hide comment
@vipulnsward

vipulnsward May 4, 2016

Contributor

🚀

Contributor

vipulnsward commented May 4, 2016

🚀

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka May 4, 2016

Member

@rkh Should we move mustermann from your personal project to Sinatra organization?

Member

namusyaka commented May 4, 2016

@rkh Should we move mustermann from your personal project to Sinatra organization?

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh May 4, 2016

Member

@namusyaka done

Member

rkh commented May 4, 2016

@namusyaka done

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka May 4, 2016

Member

@rkh Great! Thank you!

Member

namusyaka commented May 4, 2016

@rkh Great! Thank you!

vipulnsward added a commit to vipulnsward/sinatra-contrib that referenced this pull request Jul 7, 2016

Fixed decompile to start using Mustermann to match sinatra behaviour …
…that replaced normal route parsing

to use Mustermann in sinatra/sinatra#1086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment