Use Mustermann for patterns #1086

Merged
merged 4 commits into from May 4, 2016

Projects

None yet

5 participants

@rkh
Member
rkh commented Jan 30, 2016

This PR makes Sinatra use Mustermann. It also updates the pattern to what I'd like the Sinatra 2.0 syntax to be, it is generally compatible with the old syntax.

This will also lead to more meaningful errors on broken patterns.

Advanced Mustermann features are not yet exposed.

@rkh
Member
rkh commented Jan 30, 2016

Failing on JRuby atm.

@kgrz
Member
kgrz commented Mar 30, 2016

The tests are passing if I run one file at a time. I ran the helpers_test and static_test, and both pass on jruby 9.0.1.0 (2.2.2) 2015-09-02 583f336 Java HotSpot(TM) 64-Bit Server VM 25.45-b02 on 1.8.0_45-b14 +jit [darwin-x86_64]

Is this because we are using a pre-release jRuby version for the test? I see this in travis logs:

jruby 9.0.0.0.pre1 (2.2.0p0) 2015-01-20 d537cab Java HotSpot(TM) 64-Bit Server VM 24.76-b04 on 1.7.0_76-b13 +jit [linux-amd64]

zzak and others added some commits Apr 14, 2016
@zzak zzak Install latest bundler before install 84e76b8
@rkh @zzak rkh use tool/warning_filter to reduce warnings when running tests d2cd9ed
@rkh @zzak rkh inital mustermann support
7a9ffcc
@zzak zzak Update jruby to latest
0164036
@zzak
Member
zzak commented May 4, 2016

Build is green with latest JRuby (9.1.0.0)

@zzak zzak merged commit aa4ad35 into master May 4, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@zzak zzak deleted the mustermann branch May 4, 2016
@namusyaka
Contributor

Awesome 🎉

@kgrz
Member
kgrz commented May 4, 2016

👏👏👏👏

@rkh
Member
rkh commented May 4, 2016

🎉

@vipulnsward
Contributor

🚀

@namusyaka
Contributor

@rkh Should we move mustermann from your personal project to Sinatra organization?

@rkh
Member
rkh commented May 4, 2016

@namusyaka done

@namusyaka
Contributor

@rkh Great! Thank you!

@zzak zzak referenced this pull request in sinatra/sinatra-contrib May 5, 2016
Closed

Sinatra master breaks namespace spec #200

@vipulnsward vipulnsward added a commit to vipulnsward/sinatra-contrib that referenced this pull request Jul 7, 2016
@vipulnsward vipulnsward Fixed decompile to start using Mustermann to match sinatra behaviour …
…that replaced normal route parsing

to use Mustermann in sinatra/sinatra#1086
6071f6f
@vipulnsward vipulnsward referenced this pull request in sinatra/sinatra-contrib Jul 7, 2016
Closed

Fixed decompile to start using Mustermann #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment