Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bundler way of dealing with gem's stuff #119

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

lukaszx0 commented Nov 7, 2010

I was messing with sinatra source recently and found it a bit troublesome to develop it. Before running tests I had to install all gem dependecies by hand. I really like bundler way of solving this issue. Thought it would be helpfull.

Let me know what do you think.

Owner

rkh commented Nov 7, 2010

I have created a Gemfile locally for exactly the same purpose. I think there is no Dir.glob in the gemspec on purpose. If we generate the file list in the gemspec, I much prefer using git ls-files.

lukaszx0 commented Nov 9, 2010

Thanks rkh for feedback, actually I also prefere git's ls-files rather than listing files in ruby (probably that's faster, don't know), but I left with Dir.glob because mostly people don't like mixing shell executions in code, I also don't like but in this case I think it's good idea.

Pushed commit with change.

Owner

rkh commented Nov 9, 2010

Yeah, but you'll have to maintain an ignore list (*.rbc and such).

I like the patch. +1

Owner

rkh commented Nov 22, 2010

@strzalek feel free to contact Blake about this issue (bmizerany on IRC, GitHub and Twitter), I don't feel like being in the position to decide on this.

Owner

rkh commented Dec 15, 2010

Having bundler in the version control would bring more disadvantages than advantages (I use it to regularly change the Rack and Tilt versions I'm running against, but there is no point in committing that).

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment