New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase: Make #has_key? also indifferent in access #1262

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
@JonMidhir
Contributor

JonMidhir commented Mar 7, 2017

Rebases #1169 by @singpolyma without the docs update, as it's part of the Sinatra 2.0 milestone.

From original PR:

With the old strategy for indifferent access, one still had to use the
correct one of String or Symbol to ask if params#has_key? -- this fixes
that so that access is more truly indifferent.

Make #has_key? also indifferent in access
With the old strategy for indifferent access, one still had to use the
correct one of String or Symbol to ask if params#has_key? -- this fixes
that so that access is more truly indifferent.
@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Mar 7, 2017

Member

/cc #1216

Member

zzak commented Mar 7, 2017

/cc #1216

@zzak zzak merged commit 379e360 into sinatra:master Mar 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment