New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with custom error handler on bad request #1351

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
5 participants
@jkowens
Member

jkowens commented Oct 3, 2017

Make sure @params are initialized for an app, so that they exist if processing a request with a custom error handler. Currently if params are invalid an error is raised before @params is set, causing a NoMethodError for nil:NilClass down the chain. Fixes #1350.

@eguzki

eguzki approved these changes Oct 4, 2017

@olleolleolle

Thank you for fixing this!

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Oct 29, 2017

Member

#1339 candidate?

Member

zzak commented Oct 29, 2017

#1339 candidate?

@olleolleolle

This comment has been minimized.

Show comment
Hide comment
@olleolleolle

olleolleolle Oct 29, 2017

Member

@zzak I think this fits a patch release. Include it!

Member

olleolleolle commented Oct 29, 2017

@zzak I think this fits a patch release. Include it!

@jkowens

This comment has been minimized.

Show comment
Hide comment
@jkowens

jkowens Oct 30, 2017

Member

I agree, this is a backwards compatible bug fix 👍

Member

jkowens commented Oct 30, 2017

I agree, this is a backwards compatible bug fix 👍

@namusyaka

Looks good with a nit.
Thank you for the patch!

Show outdated Hide outdated lib/sinatra/base.rb
@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Feb 6, 2018

Member

Good. Thanks!

Member

namusyaka commented Feb 6, 2018

Good. Thanks!

@namusyaka namusyaka merged commit d661739 into sinatra:master Feb 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment