New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added labels guide #1359

Merged
merged 4 commits into from Nov 29, 2017

Conversation

Projects
None yet
3 participants
@CharlyJazz
Contributor

CharlyJazz commented Oct 30, 2017

No description provided.

CharlyJazz added some commits Oct 30, 2017

Update CONTRIBUTING.md
Added 3 labels

@alxers alxers referenced this pull request Nov 20, 2017

Closed

Fix #1357: Add label guide #1366

Show outdated Hide outdated CONTRIBUTING.md Outdated

CharlyJazz added some commits Nov 29, 2017

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Nov 29, 2017

Member

@CharlyJazz Sweet, do you mind squashing the commits?

Member

zzak commented Nov 29, 2017

@CharlyJazz Sweet, do you mind squashing the commits?

@CharlyJazz

This comment has been minimized.

Show comment
Hide comment
@CharlyJazz

CharlyJazz Nov 29, 2017

Contributor

@zzak, I have no idea how to do that.

But I understand what you mean, I've created several unnecessary commits.

Contributor

CharlyJazz commented Nov 29, 2017

@zzak, I have no idea how to do that.

But I understand what you mean, I've created several unnecessary commits.

@zzak zzak merged commit 62e2f0d into sinatra:master Nov 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Nov 29, 2017

Member

@CharlyJazz Nevermind, I forgot you can do that in the UI now! 🎉

Member

zzak commented Nov 29, 2017

@CharlyJazz Nevermind, I forgot you can do that in the UI now! 🎉

@CharlyJazz

This comment has been minimized.

Show comment
Hide comment
@CharlyJazz

CharlyJazz Nov 29, 2017

Contributor

@zaak What you think about this issue ? sinatra/sinatra.github.com#231

Nobody has commented anything about it. Should something be done?

Contributor

CharlyJazz commented Nov 29, 2017

@zaak What you think about this issue ? sinatra/sinatra.github.com#231

Nobody has commented anything about it. Should something be done?

@zaak

This comment has been minimized.

Show comment
Hide comment
@zaak

zaak Nov 30, 2017

@CharlyJazz I think these broken links should be fixed, definitely.

zaak commented Nov 30, 2017

@CharlyJazz I think these broken links should be fixed, definitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment