Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.2 #1455

Merged
merged 2 commits into from Mar 13, 2020
Merged

Drop support for Ruby 2.2 #1455

merged 2 commits into from Mar 13, 2020

Conversation

@epergo
Copy link
Contributor

@epergo epergo commented Jun 24, 2018

Last 20 of June official support for Ruby 2.2 was ended

One benefit of dropping support for Ruby 2.2 in Sinatra is to be able to use safe navigation operator introduced in Ruby 2.3 which could help to remove the dependency of active_support (as discussed in #1448 )

WDYT?

@namusyaka namusyaka added this to the v2.1.0 milestone Jun 24, 2018
@namusyaka namusyaka self-requested a review Jun 24, 2018
Copy link
Contributor

@namusyaka namusyaka left a comment

Good catch @epergo
I like this change. However, this change should be merge at the time of v2.1.0.
Please wait for the time.

Also, I would like @zzak or @rkh to review this change.

@namusyaka namusyaka requested review from rkh and zzak Jun 24, 2018
@dentarg dentarg mentioned this pull request Aug 23, 2018
epergo and others added 2 commits Jun 24, 2018
@jkowens jkowens merged commit 63c0cbf into sinatra:master Mar 13, 2020
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@epergo epergo deleted the epergo:drop-ruby-2.2 branch Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.