Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate warnings of keyword parameter for ruby 2.7.0 #1581

Merged
merged 2 commits into from Dec 13, 2019

Conversation

@osamtimizer
Copy link
Contributor

osamtimizer commented Dec 7, 2019

Problem

A keyword argument must be passed with ** annotation in Ruby 3.0.
https://bugs.ruby-lang.org/issues/14183

In Ruby 2.7.0, passing a keyword argument without ** occurs some warnings like warning: The last argument is used as the keyword parameter.

Solution

To avoid this warnings, I added ** annotations for keyword arguments.

Environment

ruby2.7.0-preview3

@jkowens jkowens merged commit d423f56 into sinatra:master Dec 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@osamtimizer osamtimizer deleted the osamtimizer:fix/keyword-parameter-ruby-2.7.0 branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.