Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use prepend instead of include for helpers. Fixes #1213" #1662

Merged
merged 5 commits into from
Nov 11, 2020

Conversation

namusyaka
Copy link
Member

Reverts #1214
cc @jkowens

@namusyaka namusyaka changed the title Revert "Use prepend instead of include for helpers. Fixes #1213" WIP: Revert "Use prepend instead of include for helpers. Fixes #1213" Nov 4, 2020
@namusyaka namusyaka changed the title WIP: Revert "Use prepend instead of include for helpers. Fixes #1213" Revert "Use prepend instead of include for helpers. Fixes #1213" Nov 4, 2020
Copy link
Member

@jkowens jkowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@basex
Copy link

basex commented Nov 10, 2020

Padrino doesn't load on the last versions when people use mailers. This fixes padrino/padrino-framework#2232 Can this be merged?

@namusyaka namusyaka merged commit a9649b4 into master Nov 11, 2020
@namusyaka namusyaka deleted the revert-1214-prepend-helpers branch November 11, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants