Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Include delegators only in Sinatra classes, not in Object #396
Sinatra::Delegators is getting mixed in to Object, which forces in Object#get, Object#before, etc. This messes up method_missing stuff and is just generally a bad idea. This patch seems to keep all tests passing and makes sure that the delegators are only included in the actual Sinatra classes.
Hi there, thanks for the pull request!
I can't merge this in though. This would break most Sinatra applications. We intentionally include it in Object. Otherwise classic style applications won't work. Example:
require 'sinatra' get '/' do "with your patch, it would raise a NameError" end
This is why we do this when you
The issue with