Skip to content

Server that was runned during integration test doesn't stops #412

Merged
merged 1 commit into from Nov 14, 2011

2 participants

@lest
lest commented Nov 14, 2011

There 2 processes started on my machine when running integration test:

lest     27893   0,2  1,0  2462696  21512 s002  S     8:12     0:00.97 /Users/lest/.rvm/rubies/ruby-1.9.2-p180/bin/ruby -I /Users/lest/code/sinatra/lib /Users/lest/code/sinatra/test/integration/app.rb -p 5881
lest     27892   0,0  0,0  2435544    692 s002  S     8:12     0:00.00 sh -c "/Users/lest/.rvm/rubies/ruby-1.9.2-p180/bin/ruby" -I "/Users/lest/code/sinatra/lib" "/Users/lest/code/sinatra/test/integration/app.rb" -p 5881 2>&1

In https://github.com/sinatra/sinatra/blob/master/test/integration_test.rb#L53 TERM signal is sended to process with pid 27892 (in my case) and it doesn't reflect on sinatra server with pid 27893 (it remains running). So after couple test runs I have a lot of running ruby processes.

I used exec in command and because of it ruby process replaces parent shell process and successfully stops after test.

@lest lest fix server execution in integration test
use exec in running command to allow started process to be killed
afd27d8
@rkh rkh merged commit cd68558 into sinatra:master Nov 14, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.