Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

JRuby version of integration server, started in-process w/ ScriptingContainer #479

Merged
merged 1 commit into from Mar 11, 2012

Conversation

Projects
None yet
3 participants
Contributor

nicksieger commented Mar 10, 2012

It's a little verbose and has to work around a couple of issues that diverge from behavior when launched from the command-line, but it seems to work :).

@rkh rkh added a commit that referenced this pull request Mar 11, 2012

@rkh rkh Merge pull request #479 from nicksieger/jruby-integration-tests
JRuby version of integration server, started in-process w/ ScriptingContainer
cc1ca2a

@rkh rkh merged commit cc1ca2a into sinatra:master Mar 11, 2012

Owner

rkh commented Mar 11, 2012

Thanks a ton. <3

Owner

rkh commented Mar 11, 2012

Works like a charm for WEBrick. However, with Trinidad (see trinidad branch), for some reason the vm.output/vm.error redirecting doesn't work properly.

Contributor

nicksieger commented Mar 12, 2012

Hmm. I'm guessing Trinidad is printing its output to the JVM's stdin/stdout. If I had my choice I'd prefer to see if Trinidad would accept a patch to set up its loggers to log to the JRuby runtime's provided streams. @calavera, do you have any thoughts?

Owner

rkh commented Mar 12, 2012

Nick, what's your take on these changes: https://github.com/sinatra/sinatra/pull/482/files#diff-5

@nicksieger any patch in Trinidad is really welcome. If I'm not wrong one of the log handlers in the line below is a console handler that prints directly to the stdout. I guess we should modify it to print to the runtime output stream:

https://github.com/trinidad/trinidad/blob/master/lib/trinidad/lifecycle/lifecycle_listener_base.rb#L65

Contributor

nicksieger commented Mar 12, 2012

@rkh the JRuby-specific changes look fine to me. I'd like to see if we could set up Trinidad to log to the runtime's configured streams. Maybe that will help solve some of the issues with #482.

@nicksieger I think this can work:

trinidad/trinidad#62

Contributor

nicksieger commented Mar 12, 2012

@calavera cool! Now I think we just need to fix the jruby-rack embed context to not log to System.out and System.err.

Contributor

nicksieger commented Mar 12, 2012

@kares kares referenced this pull request in jruby/jruby-rack Mar 14, 2012

Merged

embedded RackConfig with out/err streams correctly setup #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment