[trinidad] down to a single failure #482

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
2 participants
@kares
Contributor

kares commented Mar 11, 2012

  1) Failure:
test_with_trinidad_streams(IntegrationTest)
    [/home/kares/workspace/github/sinatra/test/integration_test.rb:32:in `IntegrationTest'
     org/jruby/RubyKernel.java:2045:in `instance_eval'
     /home/kares/workspace/github/sinatra/test/integration_helper.rb:214:in `test_with_trinidad_streams'
     org/jruby/RubyProc.java:270:in `call'
     org/jruby/RubyKernel.java:2076:in `send'
     org/jruby/RubyArray.java:1615:in `each'
     org/jruby/RubyArray.java:1615:in `each']:
<["a", "b"]> expected but was
<["ab"]>.

notably I've changed the integration test app to use Rack::CommonLogger over a file,
mostly due JRuby (we would need to change Java's native out/err streams to redirect otherwise) but makes the test overall most consistent by logging requests into log/app.log

I'm not sure about how to pass the streaming test if anything that's a jruby-rack bug, but my mind did not really process it ... feel free to open an issue if you feel like it's important, someone will eventually look into it someday :)

kares added some commits Mar 11, 2012

can't seem to run tests without this with rvm on linux:
RACK_ENV=development exec "/opt/local/rvm/rubies/ree-1.8.7-2011.12/bin/ruby" -I "/home/kares/workspace/github/sinatra/lib" "/home/kares/workspace/github/sinatra/test/integration/app.rb" -s thin -o 127.0.0.1 -p 5001 -e development 2>&1
loading
/home/kares/workspace/github/sinatra/lib/sinatra/base.rb:2:in `require': no such file to load -- rack (LoadError)
	from /home/kares/workspace/github/sinatra/lib/sinatra/base.rb:2
	from /home/kares/workspace/github/sinatra/lib/sinatra.rb:1:in `require'
	from /home/kares/workspace/github/sinatra/lib/sinatra.rb:1
	from /home/kares/workspace/github/sinatra/test/integration/app.rb:2:in `require'
	from /home/kares/workspace/github/sinatra/test/integration/app.rb:2
add a JRuby JS runtime so one can `bundle exec rake test` to make sur…
…e correct version of trinidad (from git) gets loaded

@kares kares referenced this pull request in trinidad/trinidad Mar 11, 2012

Closed

Eating all the logs #58

test/integration/app.rb
@@ -59,4 +62,6 @@ class Subclass < Sinatra::Base
use Subclass
-$stderr.puts "starting"
+use Rack::CommonLogger, logger # to set a custom logger

This comment has been minimized.

Show comment Hide comment
@rkh

rkh Mar 12, 2012

Owner

I'm not sure I'm 100% happy with this, as the tests are supposed to make sure logging works without any configuration.

@rkh

rkh Mar 12, 2012

Owner

I'm not sure I'm 100% happy with this, as the tests are supposed to make sure logging works without any configuration.

This comment has been minimized.

Show comment Hide comment
@kares

kares Mar 12, 2012

Contributor

You're right. I relaxed this cause we're not really interested in all the crap a server prints but only the logging coming out of the app, but of course I'm biased since I wanted to avoid printing to env['rack.errors'] as it complicates things on the JRuby side.

I'll look into "extensible" logging all the way down to jruby-rack in embedded scenarios, but I can't promise anything.

@kares

kares Mar 12, 2012

Contributor

You're right. I relaxed this cause we're not really interested in all the crap a server prints but only the logging coming out of the app, but of course I'm biased since I wanted to avoid printing to env['rack.errors'] as it complicates things on the JRuby side.

I'll look into "extensible" logging all the way down to jruby-rack in embedded scenarios, but I can't promise anything.

@rkh

This comment has been minimized.

Show comment Hide comment
@rkh

rkh Mar 12, 2012

Owner

Thanks for the Pull Request, if streaming doesn't work, we could also skip that test (as we do for webrick).

Owner

rkh commented Mar 12, 2012

Thanks for the Pull Request, if streaming doesn't work, we could also skip that test (as we do for webrick).

@kares kares referenced this pull request in trinidad/trinidad Mar 13, 2012

Merged

log to the vm streams #62

@kares kares referenced this pull request in jruby/jruby-rack Mar 14, 2012

Merged

embedded RackConfig with out/err streams correctly setup #103

@kares

This comment has been minimized.

Show comment Hide comment
@kares

kares Apr 4, 2012

Contributor

@rkh and we're all green with freshly baked trinidad 1.3.5

Contributor

kares commented Apr 4, 2012

@rkh and we're all green with freshly baked trinidad 1.3.5

@rkh rkh closed this in cab56ed May 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment