Fix routing regex #614

Merged
merged 2 commits into from Jan 26, 2013

Projects

None yet

2 participants

Contributor
zaki commented Jan 17, 2013

Hi,

I attempted a fix for sinatra/sinatra#611 by making the parsing regex somewhat more robust.

For now the specs seem to pass, but I'm not entirely sure that this is the best way going forward, so please review it and any comments would be appreciated.

I added a few more specs, such as support for lower-case URL-encoded entities according to http://tools.ietf.org/html/rfc3986#section-2.1

Thanks,
Zaki

zaki added some commits Jan 17, 2013
@zaki zaki [FIX] Make route parsing regex more robust
- fixes sinatra/sinatra/#611
- adds support for case-insensitive URL encoding
f079ce1
@zaki zaki [FIX] Support ruby 1.8 in routing regex d983c72
@rkh rkh merged commit 5a346b7 into sinatra:master Jan 26, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment