Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Syntax fix for private methods and parameters #617

Merged
merged 1 commit into from Feb 25, 2013

Conversation

Projects
None yet
2 participants
Contributor

robin850 commented Jan 21, 2013

Hi,

just a pull request that fix some syntax style in files.

Have a nice day.

Owner

rkh commented Jan 21, 2013

The method argument fixes are good, but I don't like indenting after private, tbh.

Contributor

robin850 commented Jan 21, 2013

Do I also fix this so ? ^^

Owner

rkh commented Jan 21, 2013

What's wrong with the current style?

Contributor

robin850 commented Jan 23, 2013

With the current style, code after private is sometimes indented. Do I fix it ?

Owner

rkh commented Jan 23, 2013

It is sometimes indented? Can you point me to the code? If so, I agree, we should have one style throughout the whole file, sorry for missing that part.

Contributor

robin850 commented Jan 25, 2013

Yes sometimes here, here, here also here after a public statement, here, here, here (yes, it makes a lot of « here »)

Owner

rkh commented Jan 25, 2013

Thanks. Let me think about this. I usually don't like the indented style, but use it for all Travis projects.

Contributor

robin850 commented Feb 17, 2013

Any news on this @rkh please ?

Owner

rkh commented Feb 17, 2013

Yes, any news indeed. I have been traveling since late January and will continue to do so until mid March. If I would be -1 on this, I would have already closed the issue.

Owner

rkh commented Feb 17, 2013

As I said earlier, I prefer unindented over indented.

Contributor

robin850 commented Feb 25, 2013

Sorry for the quiproquo. I've updated the code and rebased the commits. Sorry for the delay too. Let me know if I should edit something else.

Have a nice day.

@rkh rkh closed this Feb 25, 2013

@rkh rkh reopened this Feb 25, 2013

Owner

rkh commented Feb 25, 2013

Unfortunately this makes some tests fail: https://travis-ci.org/sinatra/sinatra/jobs/5036661

Contributor

robin850 commented Feb 25, 2013

@rkh : The build seems to pass. All green. Sorry it was my bad.

@rkh rkh added a commit that referenced this pull request Feb 25, 2013

@rkh rkh Merge pull request #617 from robin850/syntax_fix
Syntax fix for private methods and parameters
17198a9

@rkh rkh merged commit 17198a9 into sinatra:master Feb 25, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment