Use `headers` method instead of `header` method in `Sinatra::Response` #659

Merged
merged 1 commit into from Mar 7, 2013

Projects

None yet

2 participants

@patriciomacadden
Sinatra member

Since headers is an alias for header (see Rack::Response) and headers is widely used in Sinatra. It's confusing that in Sinatra::Response#finish both headers and header are used.

And in Sinatra::ExtendedRack#setup_close use headers as parameter just like in Sinatra::ExtendedRack#async?

@patriciomacadden patriciomacadden Use `headers` instead of `header`, since in `Rack::Response` `headers…
…` is an alias for `header` and `headers` is widely used in Sinatra. It's confusing that in `Sinatra::Response#finish` both `headers` and `header`.
9ce004f
@rkh rkh merged commit 08effab into sinatra:master Mar 7, 2013

1 check passed

Details default The Travis build passed
@patriciomacadden patriciomacadden deleted the patriciomacadden:header-headers branch Mar 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment