examples/chat.rb is not working #663

Merged
merged 1 commit into from Mar 8, 2013

Conversation

Projects
None yet
2 participants
Contributor

loveky commented Mar 8, 2013

currently this demo is not working, this is because when $("form") bind "submit" event, the form tag is not in DOM yet. Need to move form before the binding(script tag).

move the form tag before script tag
currently this demo is not working, this is because when $("form") bind "submit" event, the form tag is not in DOM yet. Need to move form before the binding.

rkh added a commit that referenced this pull request Mar 8, 2013

Merge pull request #663 from loveky/master
examples/chat.rb is not working

@rkh rkh merged commit 6017973 into sinatra:master Mar 8, 2013

1 check passed

default The Travis build passed
Details
Owner

rkh commented Mar 8, 2013

I thought on now behaves like live which is the reason jquery dropped live in a minor release?

I think I might need to drop jquery from my projects. +1 for a PR that removes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment