Cleanup unused variables #680

Merged
merged 2 commits into from Mar 15, 2013

2 participants

@vipulnsward
  1. Remove variable used to rescue
  2. We don't use params
  3. Not pretty sure if we need vars within stream blocks
@rkh
Sinatra member

Travis::Features.activate_user("single-plan", user)

Yes, to avoid warnings in some Ruby versions.

@vipulnsward

@rkh So should I update the PR keeping the stream block variables as they were before?

@rkh
Sinatra member

That's be great. I think using something like { |*| } or { |_| } would be fine, too

@vipulnsward

Changed to |_| . Also fixed another typo

@rkh
Sinatra member

\o/

@rkh rkh merged commit 623adfd into sinatra:master Mar 15, 2013

1 check passed

Details default The Travis build passed
@vipulnsward vipulnsward deleted the vipulnsward:cleanup_tests branch Mar 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment