Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added Reel as possible Rack Handler #773

Merged
merged 1 commit into from Sep 18, 2013

Conversation

Projects
None yet
3 participants

Reel now supports Rack, so we should add it to the array of possible Rack Handlers.

rkh added a commit that referenced this pull request Sep 18, 2013

Merge pull request #773 from tbuehlmann/reel_rack_handler
Added Reel as possible Rack Handler

@rkh rkh merged commit 6abd756 into sinatra:master Sep 18, 2013

Member

patriciomacadden commented Sep 18, 2013

Wait, something is missing. We should add gem 'reel-rack' as a dependency in the Gemfile.

I've just added it and when I'm running the tests, they fail. I'll look at it later, if @tbuehlmann doesn't.

You're totally right, will add it.

Added it but hadn't had the time to really look into the integration test failing. Just saw that the Reel app process couldn't be killed correctly, it was lingering around after the failing test. Could have to do with Celluloid and at_exit stuff.

Let's relocate this discussion to #774.

This was referenced Sep 27, 2013

rkh added a commit that referenced this pull request Sep 11, 2015

Merge pull request #773 from tbuehlmann/reel_rack_handler
Added Reel as possible Rack Handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment