New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reel suppport #793

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@patriciomacadden
Member

patriciomacadden commented Sep 27, 2013

See discussions in #773 and #774.

Show outdated Hide outdated lib/sinatra/base.rb
@@ -1420,7 +1420,11 @@ def run!(options = {}, &block)
handler = detect_rack_handler
handler_name = handler.name.gsub(/.*::/, '')
server_settings = settings.respond_to?(:server_settings) ? settings.server_settings : {}
server_settings.merge!(:Port => port, :Host => bind)
if handler_name == 'Reel'
server_settings.merge!(:port => port, :host => bind)
@yegortimoshenko

This comment has been minimized.

Show comment
Hide comment
@yegortimoshenko

yegortimoshenko Sep 27, 2013

You were faster! I was digging the same thing! 👍

yegortimoshenko commented Sep 27, 2013

You were faster! I was digging the same thing! 👍

@patriciomacadden

This comment has been minimized.

Show comment
Hide comment
@patriciomacadden
Member

patriciomacadden commented Sep 27, 2013

😉

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Sep 28, 2013

Member

Port/Host is the standard, shouldn't reel rather be adjusted?

Member

rkh commented Sep 28, 2013

Port/Host is the standard, shouldn't reel rather be adjusted?

@patriciomacadden

This comment has been minimized.

Show comment
Hide comment
@patriciomacadden

patriciomacadden Sep 28, 2013

Member

Yes, sure, that's what I thought. I'll send a pull request to reel-rack and then I'll update this pull request.

Member

patriciomacadden commented Sep 28, 2013

Yes, sure, that's what I thought. I'll send a pull request to reel-rack and then I'll update this pull request.

@patriciomacadden

This comment has been minimized.

Show comment
Hide comment
@patriciomacadden

patriciomacadden Sep 30, 2013

Member

I'll notify here when a new version of reel-rack gets released.

Member

patriciomacadden commented Sep 30, 2013

I'll notify here when a new version of reel-rack gets released.

@tbuehlmann

This comment has been minimized.

Show comment
Hide comment
@tbuehlmann

tbuehlmann Oct 5, 2013

Hah, just traced down the reel integration test failures only to see this PR 2 hours later, with the exact same changes. Won't open another PR then. Good job. :>

tbuehlmann commented Oct 5, 2013

Hah, just traced down the reel integration test failures only to see this PR 2 hours later, with the exact same changes. Won't open another PR then. Good job. :>

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Oct 21, 2013

Member

So what's the status on this?

Member

rkh commented Oct 21, 2013

So what's the status on this?

@yegortimoshenko

This comment has been minimized.

Show comment
Hide comment
@yegortimoshenko

yegortimoshenko Oct 21, 2013

@rkh It has been merged, but the new Reel release is not here yet.

yegortimoshenko commented Oct 21, 2013

@rkh It has been merged, but the new Reel release is not here yet.

@tbuehlmann

This comment has been minimized.

Show comment
Hide comment
@tbuehlmann

tbuehlmann Oct 21, 2013

Pinged @tarcieri a few minutes ago on IRC, waiting for an answer and gem release.

tbuehlmann commented Oct 21, 2013

Pinged @tarcieri a few minutes ago on IRC, waiting for an answer and gem release.

@tarcieri

This comment has been minimized.

Show comment
Hide comment
@tarcieri

tarcieri Oct 21, 2013

reel-rack 0.1.0 has been released with standard :Host and :Port options

tarcieri commented Oct 21, 2013

reel-rack 0.1.0 has been released with standard :Host and :Port options

@patriciomacadden

This comment has been minimized.

Show comment
Hide comment
@patriciomacadden

patriciomacadden Oct 21, 2013

Member

Thank you very much @tarcieri!

Member

patriciomacadden commented Oct 21, 2013

Thank you very much @tarcieri!

@zzak zzak added this to the future milestone Feb 6, 2015

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Feb 6, 2015

Member

I think we can't do anything about this yet because reel doesn't support Ruby 1.8, and we do: https://github.com/celluloid/reel-rack/blob/master/.travis.yml

Member

zzak commented Feb 6, 2015

I think we can't do anything about this yet because reel doesn't support Ruby 1.8, and we do: https://github.com/celluloid/reel-rack/blob/master/.travis.yml

@zzak zzak added the feature label Feb 6, 2015

@zzak zzak modified the milestones: 2.0.0, future Jan 31, 2016

@zzak zzak closed this in e61370a Jan 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment