Use Sinatra::Runner In Integration Test #840

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@apotonick
Contributor

apotonick commented Feb 12, 2014

As per PR sinatra/sinatra-contrib#122 we now use Sinatra::Runner for integration tests.

Only problem is that we have a development dependency to sinatra-contrib but @rkh promised to look into that.

@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Feb 12, 2014

Member

Hey, I just met you, and this is crazy, but there's a conflict, so rebase, maybe?

Member

rkh commented Feb 12, 2014

Hey, I just met you, and this is crazy, but there's a conflict, so rebase, maybe?

@apotonick

This comment has been minimized.

Show comment
Hide comment
@apotonick

apotonick Feb 13, 2014

Contributor

You have to merge the sinatra-contrib PR first, then point the sinatra Gemfile to the updated gem. 💋

Contributor

apotonick commented Feb 13, 2014

You have to merge the sinatra-contrib PR first, then point the sinatra Gemfile to the updated gem. 💋

@JonRowe

This comment has been minimized.

Show comment
Hide comment
@JonRowe

JonRowe Feb 13, 2014

Contributor

Hey, I just met you, and this is crazy, but there's a conflict, so rebase, maybe?

New favourite git comment

Contributor

JonRowe commented Feb 13, 2014

Hey, I just met you, and this is crazy, but there's a conflict, so rebase, maybe?

New favourite git comment

@zzak zzak added this to the 1.5.0 milestone Feb 6, 2015

@zzak zzak added the feature label Feb 6, 2015

@zzak zzak modified the milestones: 2.0.0, 1.5.0 Jan 31, 2016

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Jan 31, 2016

Member

We can merge this once it is rebased, and sinatra-contrib is updated to support Sinatra master branch

Member

zzak commented Jan 31, 2016

We can merge this once it is rebased, and sinatra-contrib is updated to support Sinatra master branch

@zzak

This comment has been minimized.

Show comment
Hide comment
@zzak

zzak Aug 17, 2016

Member

Rebased and fixed in 80016d7

Member

zzak commented Aug 17, 2016

Rebased and fixed in 80016d7

@zzak zzak closed this Aug 17, 2016

@apotonick

This comment has been minimized.

Show comment
Hide comment
@apotonick

apotonick Aug 17, 2016

Contributor

💋

Contributor

apotonick commented Aug 17, 2016

💋

@zzak

This comment has been minimized.

Show comment
Hide comment
Member

zzak commented Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment