Update Spanish README with tense, verb, and word corrections. [ci skip] #843

Merged
merged 1 commit into from Feb 17, 2014

Conversation

Projects
None yet
3 participants
@carlosplusplus
Contributor

carlosplusplus commented Feb 16, 2014

Here is a recap of the things I've updated:

  • Fixed wording to more closely match English intention.
  • Updated verb tenses to match Spanish instruction format.
  • Added missing HTTP verbs to the beginning section.

Will provided additional updates should I find them in the future. 😄

@patriciomacadden

View changes

README.es.md
@@ -24,13 +24,12 @@ ruby miapp.rb
Ver en <http://localhost:4567>.
-Es recomendable además ejecutar `gem install thin`, ya que Sinatra lo va
-a utilizar cuando esté disponible.
+Se recomienda ejecutar `gem install thin`, por que Sinatra lo utilizara si esta disponible.

This comment has been minimized.

Show comment Hide comment
@patriciomacadden

patriciomacadden Feb 16, 2014

Member

There are some typos in this sentence:

  • porque
  • utilizará
  • está
@patriciomacadden

patriciomacadden Feb 16, 2014

Member

There are some typos in this sentence:

  • porque
  • utilizará
  • está
@patriciomacadden

View changes

README.es.md
-En Sinatra, una ruta está compuesta por un método HTTP y un patrón de una URL.
-Cada ruta se asocia con un bloque:
+En Sinatra, una ruta es un método HTTP junto a un patrón de un URL.
+Cada ruta esta asociada con un bloque:

This comment has been minimized.

Show comment Hide comment
@patriciomacadden

patriciomacadden Feb 16, 2014

Member

Also in this sentence:

  • está
  • a un bloque
@patriciomacadden

patriciomacadden Feb 16, 2014

Member

Also in this sentence:

  • está
  • a un bloque
@patriciomacadden

View changes

README.es.md
@@ -56,10 +55,19 @@ end
options '/' do
.. informar algo ..
end
+
+link '/' do
+ .. afiliar con algo ..

This comment has been minimized.

Show comment Hide comment
@patriciomacadden

patriciomacadden Feb 16, 2014

Member

I would write: "afiliar a algo"

@patriciomacadden

patriciomacadden Feb 16, 2014

Member

I would write: "afiliar a algo"

@patriciomacadden

View changes

README.es.md
```
-Las rutas son comparadas en el orden en el que son definidas. La primera ruta
-que coincide con la petición es invocada.
+Las rutas son comparadas en el orden en que son definidas. La primera ruta

This comment has been minimized.

Show comment Hide comment
@patriciomacadden

patriciomacadden Feb 16, 2014

Member

I wouldn't change this sentence...

@patriciomacadden

patriciomacadden Feb 16, 2014

Member

I wouldn't change this sentence...

@@ -72,7 +80,7 @@ get '/hola/:nombre' do
end
```
-También podés acceder a los parámetros nombrados usando parámetros de bloque:
+También puede acceder a los parámetros nombrados usando parámetros de bloque:

This comment has been minimized.

Show comment Hide comment
@patriciomacadden

patriciomacadden Feb 16, 2014

Member

-I would change it to "se puede".

Edit: oh, I understand now what you want to say here. "Podés" is informal and you want to make it formal. It's ok.

@patriciomacadden

patriciomacadden Feb 16, 2014

Member

-I would change it to "se puede".

Edit: oh, I understand now what you want to say here. "Podés" is informal and you want to make it formal. It's ok.

@carlosplusplus

This comment has been minimized.

Show comment Hide comment
@carlosplusplus

carlosplusplus Feb 16, 2014

Contributor

Thank you for reviewing the corrections, @patriciomacadden.
All of the changes you recommended have been implemented.

Le agradezco mucho!

Contributor

carlosplusplus commented Feb 16, 2014

Thank you for reviewing the corrections, @patriciomacadden.
All of the changes you recommended have been implemented.

Le agradezco mucho!

@patriciomacadden

This comment has been minimized.

Show comment Hide comment
@patriciomacadden

patriciomacadden Feb 16, 2014

Member

De nada, Carlos! 😄

Member

patriciomacadden commented Feb 16, 2014

De nada, Carlos! 😄

rkh added a commit that referenced this pull request Feb 17, 2014

Merge pull request #843 from CarlosPlusPlus/master
Update Spanish README with tense, verb, and word corrections. [ci skip]

@rkh rkh merged commit 9802446 into sinatra:master Feb 17, 2014

@rkh

This comment has been minimized.

Show comment Hide comment
@rkh

rkh Feb 17, 2014

Member

@carlosplusplus Thanks for the update!
@patriciomacadden Thanks for the review!

Member

rkh commented Feb 17, 2014

@carlosplusplus Thanks for the update!
@patriciomacadden Thanks for the review!

rkh added a commit that referenced this pull request Sep 11, 2015

Merge pull request #843 from CarlosPlusPlus/master
Update Spanish README with tense, verb, and word corrections. [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment