Unify not_found and error 404 behavior (Fixes #814) #896

Merged
merged 1 commit into from Jan 31, 2016

Conversation

Projects
None yet
3 participants
@jeremyevans
Contributor

jeremyevans commented Jun 27, 2014

This makes not_found just call error 404, instead of also handling
the Sinatra::NotFound specially.

Unify not_found and error 404 behavior (Fixes #814)
This makes not_found just call error 404, instead of also handling
the Sinatra::NotFound specially.
@rkh

This comment has been minimized.

Show comment
Hide comment
@rkh

rkh Jun 28, 2014

Member

Looks good to me. Should probably not pull this in before master moves on to 1.5.

Member

rkh commented Jun 28, 2014

Looks good to me. Should probably not pull this in before master moves on to 1.5.

@rkh rkh added this to the 1.5.0 milestone Jun 28, 2014

@zzak zzak added the feature label Feb 6, 2015

zzak added a commit that referenced this pull request Jan 31, 2016

Merge pull request #896 from jeremyevans/not-found-404
Unify not_found and error 404 behavior (Fixes #814)

@zzak zzak merged commit 78dc9d8 into sinatra:master Jan 31, 2016

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

zzak added a commit that referenced this pull request Jan 31, 2016

@zzak zzak modified the milestones: 2.0.0, 1.5.0 Aug 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment