Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request #1025

Merged
merged 1 commit into from Mar 1, 2020
Merged

Remove request #1025

merged 1 commit into from Mar 1, 2020

Conversation

@ohlookitsderpy
Copy link
Contributor

ohlookitsderpy commented Feb 29, 2020

Request is deprecated (request/request#3142)

By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 馃枛

猬嗏瑔猬嗏瑔猬嗏瑔猬嗏瑔猬嗏瑔

Request is deprecated (request/request#3142)
@bertyhell

This comment has been minimized.

Copy link

bertyhell commented Feb 29, 2020

That is correct. It should be removed or at leased add a deprecated notice.
The original creator of request created a now package that is completely promise based:
https://github.com/mikeal/bent

Maybe that is a good replacement? Although that should be added in a separate PR

@sindresorhus sindresorhus merged commit f318b3d into sindresorhus:master Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.