Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review pull_request_template.md and create-list.md #1575

Closed
missmatsuko opened this issue Jun 10, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@missmatsuko
Copy link

commented Jun 10, 2019

create-list.md has at least 1 rule that's not in pull_request_template.md and could get missed by people making a PR:

Your awesome list should be named awesome-list-name"

I think these files could either be combined, or the PR template could be simplified (without removing rules), and create-list.md could have more details about each requirement.

I think if the PR template were more like a checklist or form, people would be able to follow it better.

I can give it a try, if you're ok with this suggestion.

@zoidbergwill

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

Having one canonical list with all the rules sounds valuable to me

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented Jul 4, 2019

I think if the PR template were more like a checklist or form, people would be able to follow it better.

It used to be in checkbox form, but almost everyone checked stuff without actually adhering to it, so it ended up being a useless effort.

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented Jul 4, 2019

I think these files could either be combined, or the PR template could be simplified (without removing rules), and create-list.md could have more details about each requirement.

Good point. Fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.