New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rosarior/awesome-django (dead link) #1477

Merged
merged 1 commit into from Dec 29, 2018

Conversation

3 participants
@maltsev
Copy link
Contributor

maltsev commented Dec 16, 2018

rosarior/awesome-django doesn't exist anymore.

@wsvincent would you be interested submitting your Awesome Django list?


Closes #1484
Fixes #1478

Remove rosarior/awesome-django
This awesome list doesn't exist anymore.
@wsvincent

This comment has been minimized.

Copy link

wsvincent commented Dec 21, 2018

Yes! Good call. I didn't realize the other repo was no longer active. Can you add the link to this request? https://github.com/wsvincent/awesome-django

@maltsev

This comment has been minimized.

Copy link
Contributor

maltsev commented Dec 21, 2018

Can you add the link to this request?

I think it's better if you create a separate PR for that. So the dead link removal won't depend on pending review of your list.

I also noticed a few requirements that aren't currently met (maybe there are more):

  • The repo should have awesome-list & awesome as GitHub topics.
  • Includes the Awesome badge.
  • [Table of Contents] should be named Contents, not Table of Contents.
  • Has contribution guidelines.

So before submitting your list they should be fixed.

@sindresorhus sindresorhus merged commit 5a205ed into sindresorhus:master Dec 29, 2018

@maltsev maltsev deleted the maltsev:patch-1 branch Dec 30, 2018

wsvincent added a commit to wsvincent/awesome that referenced this pull request Jan 10, 2019

Add Django
Replaces out-of-date and recently removed awesome-django repo. sindresorhus#1477

@wsvincent wsvincent referenced this pull request Jan 10, 2019

Open

Add Django #1497

@wsvincent

This comment has been minimized.

Copy link

wsvincent commented Jan 10, 2019

Thanks @maltsev for the prompt and the info on creating a proper new list submission. Just submitted the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment