Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delphi list was renamed to Pascal #1527

Merged
merged 2 commits into from Jun 10, 2019

Conversation

Projects
None yet
2 participants
@Fr0sT-Brutal
Copy link
Contributor

commented Feb 18, 2019

[Insert URL to the list here]

[Explain what this list is about and why it should be included here]

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • I have read and understood the instructions for creating a list.
  • This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list.
  • The entry in the Awesome list should:
    • Include a short description about the project/theme of the list. It should not describe the list itself.
      Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
    • Be added at the bottom of the appropriate category.
  • The list I'm submitting complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • It's the result of hard work and the best I could possibly produce.
  • Non-generated Markdown file in a GitHub repo.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
    • WTFPL and Unlicense are not acceptable licenses.
    • If you use a license badge, it should be SVG, not PNG.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

readme.md Outdated
@@ -167,7 +167,7 @@
- [Fortran](https://github.com/rabbiabram/awesome-fortran#readme)
- [PHP](https://github.com/ziadoz/awesome-php#readme)
- [Composer](https://github.com/jakoch/awesome-composer#readme) - Package manager.
- [Delphi](https://github.com/Fr0sT-Brutal/awesome-delphi#readme)
- [Pascal](https://github.com/Fr0sT-Brutal/awesome-pascal#readme) - Delphi/FreePascal/(any)Pascal

This comment has been minimized.

Copy link
@sindresorhus

sindresorhus Feb 22, 2019

Owner

Needs a better description.

This comment has been minimized.

Copy link
@Fr0sT-Brutal

Fr0sT-Brutal Feb 22, 2019

Author Contributor

What else description do you want? Language lists in common do not have them at all and I provided one. Write your own if it makes you satisfied

This comment has been minimized.

Copy link
@sindresorhus

sindresorhus Feb 26, 2019

Owner

What else description do you want?

Read the contribution guidelines:

The entry in the Awesome list should:

  • Include a short description about the project/theme of the list. It should not describe the list itself.

This comment has been minimized.

Copy link
@Fr0sT-Brutal

Fr0sT-Brutal Feb 27, 2019

Author Contributor

It's still not getting clear. It's a list for a programming language. Theme of the list is a programming language. The language is mentioned in the list name. Moreover none of other programming language lists contain a description except for several exotic and little-known ones. Why do you demand special requirements personally for my list??
And again. What kind of description do you demand? Will Pascal is an imperative and procedural programming language, which Niklaus Wirth designed in 1968–69 and published in 1970, as a small, efficient language intended to encourage good programming practices using structured programming and data structuring. It is named in honor of the French mathematician, philosopher and physicist Blaise Pascal. satisfy you?

This comment has been minimized.

Copy link
@sindresorhus

sindresorhus Jun 10, 2019

Owner

Why do you demand special requirements personally for my list??

It's not specially for your list. It's for all new contributions.

satisfy you?

No need to be snarky.

@sindresorhus sindresorhus changed the title Awesome-Delphi list evolved to Awesome-Pascal v.2 Delphi list was renamed to Pascal Feb 26, 2019

@sindresorhus sindresorhus force-pushed the sindresorhus:master branch from dc97b07 to 1b19ad6 May 30, 2019

@sindresorhus sindresorhus merged commit cddbd82 into sindresorhus:master Jun 10, 2019

@Fr0sT-Brutal Fr0sT-Brutal deleted the Fr0sT-Brutal:patch-1 branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.