Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloudflare #1590

Merged
merged 2 commits into from Aug 3, 2019

Conversation

@irazasyed
Copy link
Contributor

commented Jul 27, 2019

https://github.com/irazasyed/awesome-cloudflare

Curated list of Cloudflare worker recipes, open-source projects, guides, blogs, and other resources.

Unicorn 馃

PRs Reviewed:

@CompSciLauren

This comment has been minimized.

Copy link

commented Jul 28, 2019

Looks awesome! The way you positioned the logo looks cool to me. Running awesome-lint gave me the following error:

readme.md:23:3
脳  23:3  Link to https://twitter.com/cloudflare is dead  remark-lint:no-dead-urls
1 error

It looks like the link works though, so you might report it if it's a false positive.

@irazasyed

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

Thanks, and yes, it's some issue with the linter and I get the same error. Tried with other repos too and its the same thing.

At first, I thought it could be my network issue but looks like it is not.

I've reported the issue now: sindresorhus/awesome-lint#88 Thanks for the suggestion.

@davisonio

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Had a review of this and looks good to me!

@davisonio davisonio referenced this pull request Jul 29, 2019
@sindresorhus

This comment has been minimized.

Copy link
Owner

commented Jul 31, 2019

Examples Collection - Collection of Recipes.

Don't use title casing for the descriptions. Same applies to many other descriptions too.

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented Jul 31, 2019

Includes a succinct description of the project/theme at the top of the readme. (Example) - https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md

Not done

@irazasyed

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@sindresorhus Updated. Do I need to also lowercase company names and short-forms (Ex: PHP/Facebook or Google)?

@irazasyed

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

@sindresorhus Is there anything else I can do to get this merged? Please let me know. Thanks!

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented Aug 3, 2019

Do I need to also lowercase company names and short-forms (Ex: PHP/Facebook or Google)?

No

@sindresorhus sindresorhus merged commit 49c1339 into sindresorhus:master Aug 3, 2019

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented Aug 3, 2019

@irazasyed

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

Thank you 馃憤 :)

@irazasyed irazasyed deleted the irazasyed:patch-1 branch Aug 3, 2019

gc1175383875 added a commit to gc1175383875/awesome that referenced this pull request Aug 6, 2019

mgetzem added a commit to mgetzem/awesome that referenced this pull request Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.