Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Imba #1591

Merged
merged 3 commits into from Oct 27, 2019

Conversation

@shapkarin
Copy link
Contributor

shapkarin commented Jul 28, 2019

It's the second PR with imba after fixing awesome-lint errors. First was #1488

List url:
https://github.com/koolamusic/awesome-imba#readme

Description:
Imba is a language with a syntax inspired by ruby, it compiles to readable and performant JavaScript, and works inside the existing ecosystem.


Also we added awesome-lint as a pre-commit koolamusic/awesome-imba#18

@davisonio

This comment has been minimized.

Copy link
Contributor

davisonio commented Jul 29, 2019

  • Title should be Awesome Imba not awesome-imba
@davisonio davisonio referenced this pull request Jul 29, 2019
@shapkarin shapkarin referenced this pull request Jul 29, 2019
@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Jul 29, 2019

@davisonio fixed that

@CompSciLauren

This comment has been minimized.

Copy link
Contributor

CompSciLauren commented Jul 29, 2019

There are a few sentences that could be improved slightly:

  • "When working on client-side projects you should rather use imbapack." --> "When working on client-side projects you should use imbapack instead."
  • "You can install imba locally and set at webpack config that you need that loader." --> "You can install imba locally and in the webpack config you can set it to use that loader."
  • "Learn why imba fast, how it works and then play arounds with it." --> "Learn why imba is fast, how it works and then play around with it."
  • "A tool build in imba, that make it easier to prettier JSON." --> "A tool built in imba that makes it easier to have prettier JSON."
  • "An app that generate random Quote." --> "An app that generates random quotes."

The word "Imba" is not capitalized consistently.

Under the Contribution section, I would change it to "Are you building great stuff with Imba? Feel free to share with us!" And I would also change the part below it to say "Here are instructions. Please read the Code of Conduct as well." or maybe "Here are instructions. Please also read the Code of Conduct."

This is a great list! Nice work.

@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Jul 30, 2019

Thanks for the improvements! We added that too!

@shapkarin shapkarin referenced this pull request Jul 31, 2019
@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Jul 31, 2019

You are not following all the guidelines and there are many typos in the description here and in your Awesome list.

@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Jul 31, 2019

You need to add your email here like the instruction says: https://github.com/koolamusic/awesome-imba/blob/master/.github/CODE_OF_CONDUCT.md

@sindresorhus sindresorhus changed the title Add Imba Language Add Imba Jul 31, 2019
@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Jul 31, 2019

Thanks. I'll update that list after I read all guidelines again. I hope that they are not a lot.

@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Sep 22, 2019

@shapkarin Ping

@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Sep 23, 2019

@shapkarin Ping

@sindresorhus, thanks. I will prettify it later and let you know

@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Sep 26, 2019

@sindresorhus hi, hope that I will find some time for that and ping you till the end of the week.

@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Oct 2, 2019

@sindresorhus hello, some improvements was added

@shapkarin shapkarin force-pushed the shapkarin:imba branch 3 times, most recently from ed8f7f0 to a3a4b7b Oct 9, 2019
@shapkarin shapkarin force-pushed the shapkarin:imba branch from a3a4b7b to 2a828c9 Oct 9, 2019
@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Oct 14, 2019

You're still not following all the guidelines:

Includes a succinct description of the project/theme at the top of the readme. (Example)
Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.

@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Oct 15, 2019

Removing the description is not what I asked.

@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Oct 15, 2019

Ok. I will add description what is Imba to the lists readme and better description for this PR.

@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Oct 15, 2019

I made some changes. @sindresorhus please, correct me if I got something wrong.

@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Oct 17, 2019

I have added Imba succinct description. But it seems that we also need to fix some list descriptions and maybe remove Core Tools.

@shapkarin

This comment has been minimized.

Copy link
Contributor Author

shapkarin commented Oct 19, 2019

@sindresorhus hope now it follows all guidelines. sorry about: Don't open a Draft...

@sindresorhus sindresorhus merged commit 830bfd0 into sindresorhus:master Oct 27, 2019
@sindresorhus

This comment has been minimized.

Copy link
Owner

sindresorhus commented Oct 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.