Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libGDX #1601

Merged
merged 2 commits into from Aug 18, 2019

Conversation

@rafaskb
Copy link
Contributor

commented Aug 10, 2019

https://github.com/rafaskb/awesome-libgdx#readme

LibGDX is a powerful game framework in Java, similar to the one used by Minecraft. This list is a curated collection of resources, add-ons, and guides to help LibGDX developers make awesome games.

PR Reviews:


By submitting this pull request I confirm I've read and complied with the below requirements πŸ––

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • βœ… Add Swift
    • βœ… Add Software Architecture
    • ❌ Update readme.md
    • ❌ Add Awesome Swift
    • ❌ Add swift
    • ❌ Adding Swift
    • ❌ Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • βœ… - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • βœ… - [Framer](…) - Prototyping interactive UI designs.
    • ❌ - [iOS](…) - Resources and tools for iOS development.
    • ❌ - [Framer](…)
    • ❌ - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.
    That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • βœ… Mobile operating system for Apple phones and tablets.
    • βœ… Prototyping interactive UI designs.
    • ❌ Resources and tools for iOS development.
    • ❌ Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce.
    If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • βœ… awesome-swift
    • βœ… awesome-web-typography
    • ❌ awesome-Swift
    • ❌ AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • βœ… # Awesome Swift
    • βœ… # Awesome Web Typography
    • ❌ # awesome-swift
    • ❌ # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
    • WTFPL and Unlicense are not acceptable licenses.
    • If you use a license badge, it should be SVG, not PNG.
    • To verify that you've read all the guidelines, please add comment with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash.
      Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.
    You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

Add LibGDX
https://github.com/rafaskb/awesome-libgdx#readme

LibGDX is a powerful game framework in Java, similar to the one used by Minecraft. This list is a curated collection of resources, add-ons, and guides to help LibGDX developers make awesome games.

-----

βœ… By submitting this pull request I confirm I've read and complied with the below requirements πŸ––
βœ… Review at least 2 other open pull requests
βœ… - PR Review 1: #1589 (comment)
βœ… - PR Review 2: #1573 (comment)
βœ… Pull request's title follows the requested format.
βœ… Include a short description about the project/theme of the list.
βœ… Your entry should be added at the bottom of the appropriate category.
βœ… Your list has been around for at least 30 days.
βœ… Run awesome-lint and fix the reported issues. (Other than the false positives.)
βœ… The repo name of your list should be in lowercase slug format.
βœ… The heading title of your list should be in title case format.
βœ… Non-generated Markdown file in a GitHub repo.
βœ… The repo should have awesome-list & awesome as GitHub topics.
βœ… Not a duplicate. Please search for existing submissions.
βœ… Only has awesome items. Awesome lists are curations of the best, not everything.
βœ… Includes a project logo/illustration whenever possible.
βœ… Entries have a description.
βœ… Includes the Awesome badge.
βœ… Has a Table of Contents section.
βœ… Has an appropriate license. (CC0)
βœ… Has contribution guidelines.
βœ… Has consistent formatting and proper spelling/grammar.
βœ… Doesn't include a Travis badge.
βœ… Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme.
@rafaskb

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

unicorn

@bakke92

This comment has been minimized.

Copy link

commented Aug 14, 2019

The submission looks great! The only aviation from the guidelines I have seen is the left side "libGDX" logo, instead of right sided. ("placed at the top-right of the readme.")
Good work!

@rafaskb

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Thank you @bakke92! I updated the header to have the logo aligned to the top-right of the readme. :)

@CompSciLauren

This comment has been minimized.

Copy link

commented Aug 14, 2019

This is awesome! One thing I notice is that under Tutorials it says "For Beginners" and "For Experts". I don't think most people ever identify as an "expert" regardless of how experienced they are, and they might be more comfortable with a different phrase. Not sure what would be best, but maybe something like "Beginner" and "Advanced"? Just something to consider, feel free to do whatever you think is best.

Some linter errors that need to be fixed:

readme.md:147:4
  Γ—   20:3  ToC item "Artificial Intelligence" missing corresponding heading  remark-lint:awesome/toc
  Γ—   30:3  ToC item "For Beginners" missing corresponding heading            remark-lint:awesome/toc
  Γ—  147:4  Invalid list item link                                            remark-lint:awesome/list-item

  3 errors

This is a really great list, super useful!

@rafaskb

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Thank you for your help @CompSciLauren! I hadn't thought about the "expert" issue but it makes perfect sense, so I changed the tutorial sections to "Getting Started" and "Advanced", hopefully it's friendlier now.

Also fixed all linter issues. :)

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented Aug 18, 2019

low level => low-level

The name is libGDX. I think you should consistently use that everywhere, and not LibGDX (also here).

@rafaskb

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

Sounds good, I updated the library and the pull request to use libGDX everywhere, also fixed the low level issue.

@sindresorhus sindresorhus changed the title Add LibGDX Add libGDX Aug 18, 2019

@sindresorhus sindresorhus merged commit 0172d46 into sindresorhus:master Aug 18, 2019

@sindresorhus

This comment has been minimized.

@bakke92 bakke92 referenced this pull request Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.