Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert sticker shortcut #1015

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@aude
Copy link
Contributor

commented Jul 26, 2019

No description provided.

source/browser.ts Outdated Show resolved Hide resolved
Copy link

left a comment

Add private mode

@sindresorhus

This comment has been minimized.

Copy link
Owner

commented Sep 8, 2019

Now I'm planning to do this after #1013

It's merged.

@aude aude force-pushed the aude:insert-sticker branch from 746a085 to 7db1eca Sep 8, 2019
@aude

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

Thanks.

PR updated.

@CvX

This comment has been minimized.

Copy link
Collaborator

commented Sep 8, 2019

On the old UI the first triggering of the shortcut results with just a flash of the sticker selector. Further shortcut invocations seem to work:

sticker selector flash

Unfortunately the #941 workaround for emoji doesn't work for this issue.
TBH I don't think it's a problem, I'd merge it in anyway.

@aude

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

Thanks for checking.

I remember that being a problem, it resembles the emoji problem to me.

As a side note, the trigger is a tiny bit weird trigger in the new UI as well. It might be because the code is clicking the <a>, but if you do it with the mouse you're actually clicking the <svg> (or elements inside). I tried simulating clicking the SVG using this method, and it actually worked better.

If you want, @CvX, you could check whether that method works better in the old UI as well. But I'm open to merging this PR like it is.

@sindresorhus sindresorhus merged commit 29577c6 into sindresorhus:master Sep 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.