Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symbol as `eventName` #16

Open
sindresorhus opened this issue Dec 3, 2017 · 6 comments · May be fixed by #43
Open

Support Symbol as `eventName` #16

sindresorhus opened this issue Dec 3, 2017 · 6 comments · May be fixed by #43

Comments

@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Dec 3, 2017

Issuehunt badges

See #12 (comment) for use-case.

I think #13 should be implemented first though, so we can make sure it's not hard to define in a TS type definition.


Note: This issue has a bounty, so it's expected that you are an experienced programmer and that you give it your best effort if you intend to tackle this. Don't forget, if applicable, to add tests, docs (double-check for typos), and update TypeScript definitions. And don't be sloppy. Review your own diff multiple times and try to find ways to improve and simplify your code. Instead of asking too many questions, present solutions. The point of an issue bounty is to reduce my workload, not give me more. Include a 🦄 in your PR description to indicate that you've read this. Thanks for helping out 🙌 - @sindresorhus


IssueHunt Summary

Backers (Total: $60.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@novemberborn

This comment has been minimized.

Copy link
Collaborator

@novemberborn novemberborn commented Jan 5, 2018

We'll be able to support this in the Emittery class itself, but TypeScript cannot yet express symbol types sufficiently for use in the Emittery.Typed class. That's OK though, we can definitely tackle this now.

@sindresorhus

This comment has been minimized.

@dinoboff

This comment has been minimized.

Copy link
Contributor

@dinoboff dinoboff commented Feb 4, 2018

AFAIK, the support is still limited: they cannot be use with keyOf or as index signature parameter. It can be used in overloaded method signatures however.

@sindresorhus

This comment has been minimized.

Copy link
Owner Author

@sindresorhus sindresorhus commented Feb 17, 2018

@sindresorhus

This comment has been minimized.

Copy link
Owner Author

@sindresorhus sindresorhus commented Sep 17, 2019

The above issues has been fixed.

@issuehunt-app

This comment has been minimized.

Copy link

@issuehunt-app issuehunt-app bot commented Sep 19, 2019

@issuehunt has funded $60.00 to this issue.


@stroncium stroncium linked a pull request that will close this issue Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.