From 139ac160d0c6903a7fd84b2ffc117e13267d0e8a Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Fri, 8 Feb 2019 00:29:30 +0700 Subject: [PATCH] Fix the default value for the `filename-case` rule The default was not what was documented. It was documented as `kebabCase`, but the default in the code was `camelCase`. --- index.js | 14 ++------------ readme.md | 14 ++------------ rules/filename-case.js | 2 +- test/filename-case.js | 2 +- 4 files changed, 6 insertions(+), 26 deletions(-) diff --git a/index.js b/index.js index b2275b8e7c..e114063598 100644 --- a/index.js +++ b/index.js @@ -17,19 +17,9 @@ module.exports = { 'unicorn' ], rules: { - 'unicorn/catch-error-name': [ - 'error', - { - name: 'error' - } - ], + 'unicorn/catch-error-name': 'error', 'unicorn/explicit-length-check': 'error', - 'unicorn/filename-case': [ - 'error', - { - case: 'kebabCase' - } - ], + 'unicorn/filename-case': 'error', 'unicorn/no-abusive-eslint-disable': 'error', 'unicorn/no-process-exit': 'error', 'unicorn/throw-new-error': 'error', diff --git a/readme.md b/readme.md index db8e19fc64..aa70713059 100644 --- a/readme.md +++ b/readme.md @@ -35,19 +35,9 @@ Configure it in `package.json`. "unicorn" ], "rules": { - "unicorn/catch-error-name": [ - "error", - { - "name": "error" - } - ], + "unicorn/catch-error-name": "error", "unicorn/explicit-length-check": "error", - "unicorn/filename-case": [ - "error", - { - "case": "kebabCase" - } - ], + "unicorn/filename-case": "error", "unicorn/no-abusive-eslint-disable": "error", "unicorn/no-process-exit": "error", "unicorn/throw-new-error": "error", diff --git a/rules/filename-case.js b/rules/filename-case.js index 7badc4e6a2..8aa80b6d24 100644 --- a/rules/filename-case.js +++ b/rules/filename-case.js @@ -70,7 +70,7 @@ function splitFilename(filename) { const create = context => { const options = context.options[0] || {}; - const chosenCase = cases[options.case || 'camelCase']; + const chosenCase = cases[options.case || 'kebabCase']; const filenameWithExt = context.getFilename(); if (filenameWithExt === '') { diff --git a/test/filename-case.js b/test/filename-case.js index ba75f1994f..2249750ad1 100644 --- a/test/filename-case.js +++ b/test/filename-case.js @@ -83,7 +83,7 @@ ruleTester.run('filename-case', rule, { testCase( 'src/foo/foo_bar.js', undefined, - 'Filename is not in camel case. Rename it to `fooBar.js`.' + 'Filename is not in kebab case. Rename it to `foo-bar.js`.' ), testCase( 'src/foo/foo_bar.js',