From 4d2faac0a013e4d89d1e7f092baa6bc7d080d398 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Thu, 7 Jul 2022 23:16:22 +0200 Subject: [PATCH] Remove `prefer-event-target` from the recommended preset It requires Node.js 16 and we target Node.js 14. Fixes #1854 --- configs/recommended.js | 3 ++- docs/rules/prefer-event-target.md | 1 - readme.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configs/recommended.js b/configs/recommended.js index 672c155b54..ae62f9d455 100644 --- a/configs/recommended.js +++ b/configs/recommended.js @@ -78,7 +78,8 @@ module.exports = { 'unicorn/prefer-dom-node-dataset': 'error', 'unicorn/prefer-dom-node-remove': 'error', 'unicorn/prefer-dom-node-text-content': 'error', - 'unicorn/prefer-event-target': 'error', + // TODO: Enable this by default when targeting Node.js 16. + 'unicorn/prefer-event-target': 'off', 'unicorn/prefer-export-from': 'error', 'unicorn/prefer-includes': 'error', 'unicorn/prefer-json-parse-buffer': 'off', diff --git a/docs/rules/prefer-event-target.md b/docs/rules/prefer-event-target.md index 8660634a2d..a8a7477990 100644 --- a/docs/rules/prefer-event-target.md +++ b/docs/rules/prefer-event-target.md @@ -2,7 +2,6 @@ -βœ… *This rule is part of the [recommended](https://github.com/sindresorhus/eslint-plugin-unicorn#recommended-config) config.* While [`EventEmitter`](https://nodejs.org/api/events.html#class-eventemitter) is only available in Node.js, [`EventTarget`](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget) is also available in *Deno* and browsers. diff --git a/readme.md b/readme.md index 611391227f..23e4637f06 100644 --- a/readme.md +++ b/readme.md @@ -118,7 +118,7 @@ Each rule has emojis denoting: | [prefer-dom-node-dataset](docs/rules/prefer-dom-node-dataset.md) | Prefer using `.dataset` on DOM elements over calling attribute methods. | βœ… | πŸ”§ | | | [prefer-dom-node-remove](docs/rules/prefer-dom-node-remove.md) | Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`. | βœ… | πŸ”§ | πŸ’‘ | | [prefer-dom-node-text-content](docs/rules/prefer-dom-node-text-content.md) | Prefer `.textContent` over `.innerText`. | βœ… | | πŸ’‘ | -| [prefer-event-target](docs/rules/prefer-event-target.md) | Prefer `EventTarget` over `EventEmitter`. | βœ… | | | +| [prefer-event-target](docs/rules/prefer-event-target.md) | Prefer `EventTarget` over `EventEmitter`. | | | | | [prefer-export-from](docs/rules/prefer-export-from.md) | Prefer `export…from` when re-exporting. | βœ… | πŸ”§ | πŸ’‘ | | [prefer-includes](docs/rules/prefer-includes.md) | Prefer `.includes()` over `.indexOf()` and `Array#some()` when checking for existence or non-existence. | βœ… | πŸ”§ | πŸ’‘ | | [prefer-json-parse-buffer](docs/rules/prefer-json-parse-buffer.md) | Prefer reading a JSON file as a buffer. | | πŸ”§ | |